Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More thorough gitignore #405

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

duckontheweb
Copy link
Contributor

Description:

  • Adds a more thorough .gitignore file to cover common files/directories for Python development

@l0b0 Thanks for the push on this in this comment. I'm curious if anyone else has a different opinion on this.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #405 (2e01aa5) into main (4658999) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files          39       39           
  Lines        5169     5169           
=======================================
  Hits         4634     4634           
  Misses        535      535           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4658999...2e01aa5. Read the comment docs.

Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@duckontheweb duckontheweb requested a review from gadomski June 4, 2021 19:27
@duckontheweb duckontheweb requested a review from kbgg June 5, 2021 02:03
@duckontheweb duckontheweb merged commit d06a693 into stac-utils:main Jun 7, 2021
@duckontheweb duckontheweb deleted the complete-gitignore branch June 7, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants