Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce coverage percentage #365

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented May 27, 2021

Related Issue(s): #331

Description: Enforce the current level of code coverage, to make it easy to detect any substantial reduction and to bump it when coverage increases.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

l0b0 added 2 commits May 27, 2021 12:12
Avoids merging in PRs which decrease coverage substantially, while
encouraging bumping the number when coverage increases.
@codecov-commenter
Copy link

Codecov Report

Merging #365 (a00a61a) into main (543d17f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          36       36           
  Lines        4629     4629           
=======================================
  Hits         4140     4140           
  Misses        489      489           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543d17f...a00a61a. Read the comment docs.

@lossyrob lossyrob merged commit 86c1c6d into stac-utils:main Jun 1, 2021
@l0b0 l0b0 deleted the enforce-coverage-percentage branch June 1, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants