PERF: Avoid copy in pystac for ItemCollections #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #
#49
stac-utils/pystac#454
Description:
This uses the
preserve_dict
keyword added in stac-utils/pystac#454 to avoid a deepcopy on the items passed topystac.ItemCollection
. In these cases, we have the only reference to dictionary so it should be safe to mutate. As a small test:That took ~20s on the latest released version and 14s after applying this change.
PR Checklist: