Set client Catalog as Item root in ItemSearch #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossyrob
changed the title
|
I merged this change into #74 |
gjoseph92
added a commit
to gjoseph92/planetary-computer-sdk-for-python
that referenced
this pull request
Oct 28, 2021
Losing the root collection was causing `to_dict()` on signed `ItemCollections` to be extremely slow, like stac-utils/pystac#546. By preserving the root catalog stac-utils/pystac-client#72, it's much faster.
TomAugspurger
pushed a commit
to microsoft/planetary-computer-sdk-for-python
that referenced
this pull request
Oct 29, 2021
Losing the root collection was causing `to_dict()` on signed `ItemCollections` to be extremely slow, like stac-utils/pystac#546. By preserving the root catalog stac-utils/pystac-client#72, it's much faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): # stac-utils/pystac#546
Description:
This PR passes in the client Catalog as the root of Items in an ItemCollection for ItemSearchs produced by that client Catalog.
This allows PySTAC logic that depends on reading the root of an object to perform significantly faster.
This makes the assumption that the root of the Items produced by a STAC API search should always be pointed back to the STAC API, which I think is a fair assumption.
This PR relies on changes in PySTAC contained in stac-utils/pystac#549. Making this PR as a draft until upstream changes are available.
PR Checklist: