Reduce the number of imported packages #161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure that "set_" functions should return the models. For now, I return them invisibly until I determine if they need to be returned.
…_model()` Since `model` can also be a function, we should not call it `model_name`
Depending on the context, the `fn_body` returns differently formatted versions of the code. This code converts to a unified format before hashing
The base R functions `order()` cannot consistently sort lexicographically. In R build context, the sorting is different from interactive context.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
As of #101 we now have more than 20 Imports which produces a note prompting us to move as many imported packages as possible to Suggests.
This PR does exactly that
Approach
Packages that are only used within single modules (or single methods within modules) are now moved to Suggests and checks are introduced in these functions to warn the user about the missingness of the packages.
Known issues
This PR is built on top of another PR that needs to be merged before this is ready
Checklist
I have documented any new features introducedIf the PR adds a new feature, please add an entry inNEWS.md