-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly render benchmark vignette in CRAN vs non-CRAN context #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 47af156.
e6cbf23
to
07197d9
Compare
RasmusSkytte
commented
Jan 13, 2025
b2b70f8
to
aafd47e
Compare
This should be the last thing we need before we can release the next version of SCDB |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Fixes #162
Approach
A PR on diseaystore (ssi-dk/diseasystore#185) fixed an issue with the data being plotted for the benchmarks on CRAN.
This PR implements these changes in the logic to ensure that when rendering on CRAN, we use the newest benchmarks.
In addition, the figures created on CRAN are the low resolution vignette figures that R uses for its vignettes.
These plots are adjusted so that they are readable now.
We therefore now first check if we are in a CRAN or non-CRAN context and then swap which benchmarks we plot and how they are plotted.
Example figures in a non-CRAN context (i.e. our website):
![benchmark_1-1](https://private-user-images.githubusercontent.com/8895829/402547284-615ab88f-d535-4f0d-8480-a7af5bf81b2b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTM3OTksIm5iZiI6MTczOTU5MzQ5OSwicGF0aCI6Ii84ODk1ODI5LzQwMjU0NzI4NC02MTVhYjg4Zi1kNTM1LTRmMGQtODQ4MC1hN2FmNWJmODFiMmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDQyNDU5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTVkOWE4NWMwOTU0MGM0YjkxYjQ0ZWFlMzE3MmZmN2U4YTNmNzViZGQ4NjE1NTg2ZmUyNmMyYzkxMDk5M2Y3YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Zy0qhcQNiJFTmiu9CyMQB5I3hqNEFPdvFu_vAX7GwJU)
Example figures in a CRAN context (i.e. for the pre-rendered vignettes):
![Uden titel](https://private-user-images.githubusercontent.com/8895829/402548344-e16cee17-b3c0-45e1-9cb0-8894e36b4d1e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTM3OTksIm5iZiI6MTczOTU5MzQ5OSwicGF0aCI6Ii84ODk1ODI5LzQwMjU0ODM0NC1lMTZjZWUxNy1iM2MwLTQ1ZTEtOWNiMC04ODk0ZTM2YjRkMWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDQyNDU5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzgzODc2OTFmODY0YjEyYjRiNDI5ZGRmZTM3NjQzYjgzNzU0NzYzYTk4ZTUxZWY4MDFkMzliNDljNzQ1NjBiZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Caz1FKlGcLbenrL-aNp1WeFDWT0YKGRJcGi2IF0bRqs)
Known issues
N/A
Checklist
NEWS.md