Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT rep jacket fix #994

Merged
merged 3 commits into from
Jan 16, 2025
Merged

NT rep jacket fix #994

merged 3 commits into from
Jan 16, 2025

Conversation

Chorden523
Copy link

@Chorden523 Chorden523 commented Jan 15, 2025

Что этот PR делает

Исправляет отображение жакета НТРа на кукле и на объекте

Почему это хорошо для игры

Правильное отображения жакета НТРа

Изображения изменений

Как было:
ntr_jacket

Как стало:
ntr_jacket_2

Тестирование

Компилил и смотрел не пропала ли проблема с жакетом НТР

Changelog

🆑
fix: Застёгнутый и расстёгнутый жакет НТРа теперь отображается правильно.
/:cl:

Copy link

sourcery-ai bot commented Jan 15, 2025

Reviewer's Guide by Sourcery

This PR moves all clothing items from the objects module to the clothing module and fixes the display of the Nanotrasen Representative's jacket.

Class diagram showing clothing file structure changes

classDiagram
    class ClothingModule {
        +code/
        +icons/
    }
    class CodeStructure {
        +gloves/
        +head/
        +mod/
        +spacesuits/
        +suits/
        +under/
    }
    class IconsStructure {
        +obj/
        +mob/
    }
    ClothingModule --> CodeStructure
    ClothingModule --> IconsStructure
    note for ClothingModule "Moved from objects/ to clothing/"
Loading

File-Level Changes

Change Details Files
Moved clothing items to a new module
  • Moved clothing definitions from various files in modular_bandastation/objects/code/items/clothing to modular_bandastation/clothing/code.
  • Updated icon paths to reflect the new module location.
  • Created new module files _clothing.dm and _clothing.dme for clothing items.
  • Updated module definitions in modular_bandastation.dme and _objects.dme to reflect the module move
modular_bandastation/objects/code/items/clothing/suits/cloaks.dm
modular_bandastation/objects/code/items/clothing/suits/jobs.dm
modular_bandastation/objects/code/items/clothing/suits/wintercoats.dm
modular_bandastation/objects/code/items/clothing/under/jobs/magistrate.dm
modular_bandastation/objects/code/items/clothing/gloves/gloves.dm
modular_bandastation/objects/code/items/clothing/suits/armor.dm
modular_bandastation/objects/code/items/clothing/under/jobs/nanotrasen_representative.dm
modular_bandastation/objects/code/items/clothing/head/hat.dm
modular_bandastation/objects/code/items/clothing/head/jobs.dm
modular_bandastation/objects/code/items/clothing/head/soft_caps.dm
modular_bandastation/objects/code/items/clothing/mod/types/praetorian/mod_theme.dm
modular_bandastation/objects/code/items/clothing/spacesuits/plasmaman.dm
modular_bandastation/objects/code/items/clothing/under/jobs/blueshield.dm
modular_bandastation/objects/code/items/clothing/under/jobs/plasmaman/blueshield.dm
modular_bandastation/objects/code/items/clothing/under/jobs/research.dm
modular_bandastation/modular_bandastation.dme
modular_bandastation/objects/_objects.dme
modular_bandastation/clothing/_clothing.dm
modular_bandastation/clothing/_clothing.dme

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! label Jan 15, 2025
@dj-34
Copy link
Collaborator

dj-34 commented Jan 15, 2025

не имеет смысла

@Chorden523 Chorden523 changed the title Clothing module + NT rep jacket fix NT rep jacket fix Jan 15, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 15, 2025
@dj-34 dj-34 merged commit ccd0eaf into ss220club:master Jan 16, 2025
19 of 24 checks passed
@Chorden523 Chorden523 deleted the clothing_module branch January 16, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! 📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants