Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captain access for captain display case #975

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Gaxeer
Copy link
Collaborator

@Gaxeer Gaxeer commented Jan 12, 2025

Что этот PR делает

Капитанский доступ для капитанского дисплейкейса

Почему это хорошо для игры

Не надо ломать дисплейкейс когда хочешь взять антикварный лазер.
Можно положить лазер обратно

Тестирование

Да, даже протестировал на всякий

Changelog

🆑
tweak: Капитанский доступ для капитанского дисплейкейса
/:cl:

Summary by Sourcery

Allow captains to access the captain's display case.

New Features:

  • Captains can now access the captain's display case.

Tests:

  • The change has been tested.

Copy link

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This pull request implements captain access for the captain display case. This is achieved by adding a new object, /obj/structure/displaycase/captain, which inherits from the base display case object and sets the req_access variable to ACCESS_CAPTAIN.

Sequence diagram for Captain's Display Case access control

sequenceDiagram
    actor Captain
    actor CrewMember
    participant DisplayCase

    Captain->>DisplayCase: Attempt access
    DisplayCase->>DisplayCase: Check access level
    DisplayCase-->>Captain: Grant access

    CrewMember->>DisplayCase: Attempt access
    DisplayCase->>DisplayCase: Check access level
    DisplayCase-->>CrewMember: Deny access
Loading

Class diagram for Captain's Display Case inheritance

classDiagram
    DisplayCase <|-- CaptainDisplayCase
    class DisplayCase {
        +req_access
    }
    class CaptainDisplayCase {
        +req_access: [ACCESS_CAPTAIN]
    }
    note for CaptainDisplayCase "Requires captain access level"
Loading

File-Level Changes

Change Details Files
Added a new object /obj/structure/displaycase/captain which requires captain access.
  • Set the req_access variable to ACCESS_CAPTAIN for the new object.
  • Added the new object definition to the _objects.dme file to register the new object type with the game's object system.
modular_bandastation/objects/_objects.dme
modular_bandastation/objects/code/structures/displaycase.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Legendaxe Legendaxe merged commit 21bea60 into ss220club:master Jan 12, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants