Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyberiad: Remap arrivals #947

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Conversation

dj-34
Copy link
Collaborator

@dj-34 dj-34 commented Dec 31, 2024

  1. Ремап прибытия, сделал его более симметричным и красивым.
  2. Пофиксил возможность захода в трансит трубы в гетто.
  3. Убрал страшную челку в порте аррайвал шаттла путём ремапа нижнего уровня под прибытием.
  4. Памятная табличка перемещена из прибытия в отбытие.
  5. Небольшие визуальные изменения и перестановка машинерии.
  6. Добавил чуть больше направителей в западной части гетто.
  7. Добавил точки перехода через трансит трубы.

Summary by Sourcery

Enhancements:

  • Remap the lower level beneath the arrival area to improve visuals and rearrange machinery.

Copy link

sourcery-ai bot commented Dec 31, 2024

Reviewer's Guide by Sourcery

This pull request reworks the arrival area of Cyberiad, making it more symmetrical and visually appealing. It also fixes an issue with the transit pipe access in the ghetto, removes an obstruction in the arrival shuttle port, moves a plaque from arrival to departure, and includes minor visual and machinery adjustments.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Arrival area rework
  • Redesigned the arrival area for improved symmetry and aesthetics.
_maps/map_files/Cyberiad/Cyberiad.dmm
Ghetto transit pipe fix
  • Fixed the ability to enter the transit pipe in the ghetto area.
_maps/map_files/Cyberiad/Cyberiad.dmm
Arrival shuttle port visual improvement
  • Removed an obstruction in the arrival shuttle port by remapping the lower level.
_maps/map_files/Cyberiad/Cyberiad.dmm
Plaque relocation
  • Moved the commemorative plaque from the arrival area to the departure area.
_maps/map_files/Cyberiad/Cyberiad.dmm
Minor visual and machinery adjustments
  • Implemented small visual changes and rearranged machinery in the map.
_maps/map_files/Cyberiad/Cyberiad.dmm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один. label Dec 31, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. All of the files are larger than we can process. We're working on it!

Copy link
Collaborator

@AyIong AyIong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот бы твои ПРы не были на ВСЮ карту

@dj-34
Copy link
Collaborator Author

dj-34 commented Jan 2, 2025

Вот бы твои ПРы не были на ВСЮ карту

оно на всю потому что переместил объект из одного конца в другой

@dj-34 dj-34 merged commit 85a3b70 into ss220club:master Jan 2, 2025
21 of 24 checks passed
@dj-34 dj-34 deleted the cyberiad_arrivals_remap branch January 2, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants