Merge upstream 05.09.24

.github/ISSUE_TEMPLATE/bug_report_form.yml

@@ -0,0 +1,65 @@
+name: Bug Report
+description: Create a report to help reproduce and fix the issue.
+body:
+  - type: markdown
+    attributes:
+      value: |
+        # **Please read the following guidelines. Follow all instructions or else your issue is subject to closure.**
+        ## If you use the "Report Issue" button in the top-right corner of the game, it will automatically fill in some of the information below.
+
+        If you are reporting an issue found in another branch or codebase, you _must_ link the branch or codebase repo in your issue report or it will be closed.
+        For branches, If you have not pushed your code up, please either reproduce it on master or push your code up before making an issue report.
+        For other codebases, if you do not have a public code repository you will be refused help unless you can completely reproduce the issue on our master branch.
+  - type: input
+    id: reporting-version
+    attributes:
+      label: "Client Version:"
+      description: |
+        The BYOND version you are using to report this issue. You can find this information in the bottom left corner of the "About BYOND" window in the BYOND client.
+        It is strongly recommended that you include this, especially for concerns on the visual aspects of the game.
+      placeholder: "xxx.xxxx"
+    validations:
+      required: false
+  - type: textarea
+    id: issue-summary
+    attributes:
+      label: "Issue Summary:"
+      description: |
+        Briefly explain your issue in a few plain sentences. You may copy and paste the issue title here if it is suitable.
+      placeholder: |
+        "When I do X, Y happens instead of Z."
+        "X on Y map has Z issue."
+    validations:
+      required: true
+  - type: input
+    id: round-id
+    attributes:
+      label: "Round ID:"
+      description: |
+        If you discovered this issue from playing tgstation hosted servers, the Round ID can be found in the Status panel or retrieved from https://statbus.space/
+        The Round ID lets us look up valuable information and logs for the round the bug happened. Leave this blank if there is no round ID.
+      placeholder: "XXXXXX"
+    validations:
+      required: false
+  - type: textarea
+    id: test-merges
+    attributes:
+      label: "Test Merge Information:"
+      description: |
+        If you're certain the issue is to be caused by a test merge [OOC Tab -> Show Server Revision], report it in the pull request's comment section rather than on the tracker.
+        If you're unsure you can refer to the issue number by prefixing said number with #. The issue number can be found beside the title after submission of this form.
+    validations:
+      required: false
+  - type: textarea
+    id: reproduction
+    attributes:
+      label: "Reproduction Steps:"
+      description: |
+        Describe the steps to reproduce the issue in detail. Include any relevant information, such as the map, round type, and any other factors that may be relevant.
+        If it is a runtime-related error, please include the runtime here as that is pertient information. Issues are not for oddities introduced by admin varedits, ensure these occur in normal circumstances.
+      placeholder: |
+        1. Go to the X location
+        2. Do Y action
+        3. Observe Z result
+    validations:
+      required: true

.github/gbp.toml

@@ -23,3 +23,4 @@ reset_label = "GBP: Reset"
 "Sound" = 3
 "Sprites" = 3
 "Unit Tests" = 6
+"Wallening Revert Recovery" = 10

.github/workflows/update_tgs_dmapi.yml

@@ -21,6 +21,7 @@ jobs:
 
     - name: Apply DMAPI update
       uses: tgstation/tgs-dmapi-updater@v2
+      id: dmapi-update
       with:
         header-path: 'code/__DEFINES/tgs.dm'
         library-path: 'code/modules/tgs'
@@ -41,7 +42,7 @@ jobs:
         source_branch: "tgs-dmapi-update"
         destination_branch: "master"
         pr_title: "Automatic TGS DMAPI Update"
-        pr_body: "This pull request updates the TGS DMAPI to the latest version. Please note any changes that may be breaking or unimplemented in your codebase by checking what changes are in the definitions file: code/__DEFINES/tgs.dm before merging."
+        pr_body: "This pull request updates the TGS DMAPI to the latest version. Please note any changes that may be breaking or unimplemented in your codebase by checking what changes are in the definitions file: code/__DEFINES/tgs.dm before merging.\n\n${{ steps.dmapi-update.outputs.release-notes }}"
         pr_label: "Tools"
         pr_allow_empty: false
         github_token: ${{ secrets.COMFY_ORANGE_PAT }}

README.md

@@ -20,6 +20,8 @@ This is the codebase for the /tg/station flavoured fork of SpaceStation 13.
 
 Space Station 13 is a paranoia-laden round-based roleplaying game set against the backdrop of a nonsensical, metal death trap masquerading as a space station, with charming spritework designed to represent the sci-fi setting and its dangerous undertones. Have fun, and survive!
 
+*All github inquiries (such as moderation actions) may be handled via the /tg/station discord [#coding-general](https://discord.com/channels/326822144233439242/326831214667235328). Simply ping the `@Maintainer` role, following the guide on asking questions located in the channel description, with your issue!*
+
 ## DOWNLOADING
 [Downloading](.github/guides/DOWNLOADING.md)
 

_maps/RandomRuins/IceRuins/icemoon_surface_pizza.dmm

@@ -300,7 +300,6 @@
 /area/ruin/pizzeria)
 "kr" = (
 /obj/structure/table,
-/obj/item/trash/waffles,
 /obj/effect/turf_decal/tile/blue/opposingcorners{
 	dir = 1
 	},

_maps/RandomRuins/IceRuins/icemoon_underground_comms_agent.dmm

@@ -451,12 +451,8 @@
 /area/ruin/comms_agent)
 "xq" = (
 /obj/effect/decal/cleanable/dirt,
-/obj/item/radio/intercom{
-	pixel_x = 31;
-	syndie = 1;
-	freerange = 1;
-	name = "syndicate radio intercom";
-	desc = "A custom-made Syndicate-issue intercom used to transmit on all Nanotrasen frequencies. Particularly expensive."
+/obj/item/radio/intercom/syndicate/freerange{
+	pixel_x = 31
 	},
 /obj/structure/table/reinforced,
 /obj/machinery/fax{

_maps/RandomRuins/LavaRuins/lavaland_biodome_beach.dmm

@@ -406,6 +406,10 @@
 /obj/machinery/atmospherics/pipe/smart/manifold4w/scrubbers/hidden/layer4,
 /turf/open/floor/plating,
 /area/ruin/powered/beach)
+"mv" = (
+/obj/effect/spawner/message_in_a_bottle/low_prob,
+/turf/open/misc/beach/coast,
+/area/ruin/powered/beach)
 "mw" = (
 /obj/structure/flora/coconuts,
 /turf/open/misc/beach/sand,
@@ -985,6 +989,7 @@
 	dir = 1
 	},
 /obj/machinery/light/directional/south,
+/obj/effect/spawner/message_in_a_bottle/low_prob,
 /turf/open/misc/beach/coast/corner{
 	dir = 8
 	},
@@ -1990,7 +1995,7 @@ bG
 bL
 VI
 VI
-yT
+mv
 pz
 Eu
 pz