Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMI-MODULAR] Supply Pods subtype - teleporter #380

Merged
merged 6 commits into from
Jul 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions code/__DEFINES/cargo.dm
Original file line number Diff line number Diff line change
@@ -12,6 +12,7 @@
#define STYLE_INVISIBLE 12
#define STYLE_GONDOLA 13
#define STYLE_SEETHROUGH 14
#define STYLE_TELEPORT 15 // BANDASTATION EDIT

#define POD_SHAPE 1
#define POD_BASE 2
Original file line number Diff line number Diff line change
@@ -201,7 +201,7 @@ GLOBAL_LIST_EMPTY(order_console_products)
ordered_paths += item.item_path
podspawn(list(
"target" = get_turf(living_user),
"style" = STYLE_BLUESPACE,
"path" = /obj/structure/closet/supplypod/teleporter, // BANDASTATION EDIT - Original: "style" = STYLE_BLUESPACE,
"spawn" = ordered_paths,
))
grocery_list.Cut()
2 changes: 1 addition & 1 deletion code/game/objects/items/choice_beacon.dm
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@
/obj/item/choice_beacon/proc/spawn_option(obj/choice_path, mob/living/user)
podspawn(list(
"target" = get_turf(src),
"style" = STYLE_BLUESPACE,
"path" = /obj/structure/closet/supplypod/teleporter, // BANDASTATION EDIT - Original: "style" = STYLE_BLUESPACE,
"spawn" = choice_path,
))

2 changes: 1 addition & 1 deletion code/modules/cargo/supplypod.dm
Original file line number Diff line number Diff line change
@@ -717,7 +717,7 @@
pod.transform = matrix().Turn(rotation)
pod.layer = FLY_LAYER
SET_PLANE_EXPLICIT(pod, ABOVE_GAME_PLANE, src)
if (pod.style != STYLE_INVISIBLE)
if (pod.style != STYLE_INVISIBLE && pod.style != STYLE_TELEPORT) // BANDASTATION EDIT. Original: if (pod.style != STYLE_INVISIBLE)
animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING) //Make the pod fall! At an angle!
addtimer(CALLBACK(src, PROC_REF(endLaunch)), pod.delays[POD_FALLING], TIMER_CLIENT_TIME) //Go onto the last step after a very short falling animation

4 changes: 4 additions & 0 deletions modular_bandastation/aesthetics/_aesthetics.dm
Original file line number Diff line number Diff line change
@@ -2,3 +2,7 @@
name = "Эстетика"
desc = "Обновление визуального ряда"
author = "larentoun, Aylong220"

/datum/modpack/aesthetics/post_initialize()
. = ..()
GLOB.podstyles += list(list(POD_SHAPE_OTHER, FALSE, FALSE, FALSE, FALSE, RUBBLE_NONE, "Портал доставки", "Высокотехнологичный портал для межзвездной доставки. Обеспечивает мгновенный доступ к товарам из любой точки вселенной."))
3 changes: 3 additions & 0 deletions modular_bandastation/aesthetics/_aesthetics.dme
Original file line number Diff line number Diff line change
@@ -44,6 +44,9 @@
// Radio
#include "radio/code/radio.dm"

// Supply Pods
#include "supply_pods/code/supply_pods.dm"

// Walls
#include "walls/code/walls.dm"

31 changes: 31 additions & 0 deletions modular_bandastation/aesthetics/supply_pods/code/supply_pods.dm
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/obj/structure/closet/supplypod/teleporter
style = STYLE_TELEPORT
bluespace = TRUE
explosionSize = list(0,0,0,0)
fallingSound = null
landingSound = SFX_PORTAL_CREATED
openingSound = SFX_PORTAL_ENTER
leavingSound = SFX_PORTAL_CLOSE
pod_flags = FIRST_SOUNDS

/obj/structure/closet/supplypod/teleporter/setStyle(chosenStyle)
. = ..()
icon = 'icons/obj/anomaly.dmi'
icon_state = "portal"

/obj/effect/pod_landingzone/setupSmoke(rotation)
if(pod.style == STYLE_TELEPORT)
return
. = ..()

/obj/effect/pod_landingzone/drawSmoke()
if(pod.style == STYLE_TELEPORT)
return
. = ..()

/obj/effect/pod_landingzone/endLaunch()
if(pod.style == STYLE_TELEPORT)
pod.pixel_x = 0
pod.pixel_z = 0
pod.transform = matrix()
. = ..()

Unchanged files with check annotations Beta

continue
message_strings += "This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking."
TEST_NOTICE(src, jointext(message_strings, "\n"))

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (birdshot) / run_integration_tests

Birdshot Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (deltastation) / run_integration_tests

Delta Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (gateway_test) / run_integration_tests

Gateway Test: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (icebox) / run_integration_tests

Ice Box Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (metastation) / run_integration_tests

MetaStation: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (multiz_debug) / run_integration_tests

MultiZ Debug: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (northstar) / run_integration_tests

NorthStar: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (runtimestation) / run_integration_tests

Runtime Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (tramstation) / run_integration_tests

Tramstation: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Integration Tests (wawastation) / run_integration_tests

Wawastation: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.

Check notice on line 22 in code/modules/unit_tests/subsystem_init.dm

GitHub Actions / Alternate Tests (515, 1627, runtimestation) / run_integration_tests

Runtime Station: /datum/unit_test/subsystem_init

Lua Scripting (/datum/controller/subsystem/lua) is a subsystem meant to initialize but could not get initialized. The subsystem reported the following: Error initializing SSlua: FAILED (Couldn't find call_proc_by_id) This subsystem is marked as SS_OK_TO_FAIL_INIT. This is still a bug, but it is non-blocking.