Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #240

Merged
merged 22 commits into from
Apr 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
57ff27c
bug fixes and code refactor for AI, malf or otherwise (#82590)
Metekillot Apr 28, 2024
74b4715
fix roleless poll ignores not working (#82911)
13spacemen Apr 28, 2024
4fce385
Automatic changelog for PR #82590 [ci skip]
comfyorange Apr 28, 2024
05dd356
Automatic changelog for PR #82911 [ci skip]
comfyorange Apr 28, 2024
88143d2
Fixes runtime in z level update (#82898)
JohnFulpWillard Apr 28, 2024
4a5cb3e
Makes the cutter lint actually work (#82913)
LemonInTheDark Apr 28, 2024
922017a
Adds tinyfans to the arrival shuttles (#82915)
improvedname Apr 28, 2024
dfc85d7
Automatic changelog for PR #82915 [ci skip]
comfyorange Apr 28, 2024
55a5a05
Fix the materials box dropping its contents on creation (#82892)
msgerbs Apr 28, 2024
7d3f376
Automatic changelog for PR #82892 [ci skip]
comfyorange Apr 28, 2024
cdd7665
Unarmed Attacks Support Multiple Verbs (#82876)
13spacemen Apr 28, 2024
84d7b0c
Automatic changelog for PR #82876 [ci skip]
comfyorange Apr 28, 2024
350a27d
Automatic changelog compile [ci skip]
actions-user Apr 29, 2024
1fb8ac6
Adds a funny scene when getting Sisyphus achievement (#82897)
intercepti0n Apr 29, 2024
d72724d
Automatic changelog for PR #82897 [ci skip]
comfyorange Apr 29, 2024
46861e4
Netguardian darkvision & visual tweaks (#82919)
Jacquerel Apr 29, 2024
4828dd8
Automatic changelog for PR #82919 [ci skip]
comfyorange Apr 29, 2024
d86a44a
Updates tips of the round to exclude mentions of virologist, and incl…
YesterdaysPromise Apr 29, 2024
18cb6a9
Automatic changelog for PR #82923 [ci skip]
comfyorange Apr 29, 2024
c761738
Eigenstasium Fix (#82930)
SyncIt21 Apr 29, 2024
a57d02b
Automatic changelog for PR #82930 [ci skip]
comfyorange Apr 29, 2024
7e94402
Use defines for spellbook categories (#82938)
larentoun Apr 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unarmed Attacks Support Multiple Verbs (tgstation#82876)
## About The Pull Request
Unarmed attacks, aka punching people, now is a list and supports having
multiple verbs
## Why It's Good For The Game
More flavor, RP, realism

Lizard claws used to only "slash", now they can "slash" "scratch" "claw"
Ethereals have "singe" in addition to "burn"
Podmen can "lash" in addition to "slash"
Heads can "chomp" in addition to "bite"
## Changelog
:cl:
code: Unarmed attacks (punches, etc.) now support multiple attack verbs
instead of only one
/:cl:
13spacemen authored Apr 28, 2024
commit cdd7665bc66faea1552f7b8624b90da3cf95c059
Original file line number Diff line number Diff line change
@@ -294,7 +294,7 @@

/// Make our arm do slashing effects
/datum/status_effect/golem/diamond/proc/set_arm_fluff(obj/item/bodypart/arm/arm)
arm.unarmed_attack_verb = "slash"
arm.unarmed_attack_verbs = list("slash")
arm.grappled_attack_verb = "lacerate"
arm.unarmed_attack_effect = ATTACK_EFFECT_CLAW
arm.unarmed_attack_sound = 'sound/weapons/slash.ogg'
@@ -315,7 +315,7 @@
/datum/status_effect/golem/diamond/proc/reset_arm_fluff(obj/item/bodypart/arm/arm)
if (!arm)
return
arm.unarmed_attack_verb = initial(arm.unarmed_attack_verb)
arm.unarmed_attack_verbs = initial(arm.unarmed_attack_verbs)
arm.unarmed_attack_effect = initial(arm.unarmed_attack_effect)
arm.unarmed_attack_sound = initial(arm.unarmed_attack_sound)
arm.unarmed_miss_sound = initial(arm.unarmed_miss_sound)
2 changes: 1 addition & 1 deletion code/modules/mob/living/carbon/human/_species.dm
Original file line number Diff line number Diff line change
@@ -1068,7 +1068,7 @@ GLOBAL_LIST_EMPTY(features_by_species)
attacking_bodypart = brain.get_attacking_limb(target)
if(!attacking_bodypart)
attacking_bodypart = user.get_active_hand()
var/atk_verb = attacking_bodypart.unarmed_attack_verb
var/atk_verb = pick(attacking_bodypart.unarmed_attack_verbs)
var/atk_effect = attacking_bodypart.unarmed_attack_effect

if(atk_effect == ATTACK_EFFECT_BITE)
4 changes: 2 additions & 2 deletions code/modules/surgery/bodyparts/_bodyparts.dm
Original file line number Diff line number Diff line change
@@ -165,8 +165,8 @@

/// Type of an attack from this limb does. Arms will do punches, Legs for kicks, and head for bites. (TO ADD: tactical chestbumps)
var/attack_type = BRUTE
/// the verb used for an unarmed attack when using this limb, such as arm.unarmed_attack_verb = punch
var/unarmed_attack_verb = "bump"
/// the verbs used for an unarmed attack when using this limb, such as arm.unarmed_attack_verbs = list("punch")
var/list/unarmed_attack_verbs = list("bump")
/// if we have a special attack verb for hitting someone who is grappled by us, it goes here.
var/grappled_attack_verb
/// what visual effect is used when this limb is used to strike someone.
2 changes: 1 addition & 1 deletion code/modules/surgery/bodyparts/head.dm
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
scars_covered_by_clothes = FALSE
grind_results = null
is_dimorphic = TRUE
unarmed_attack_verb = "bite"
unarmed_attack_verbs = list("bite", "chomp")
unarmed_attack_effect = ATTACK_EFFECT_BITE
unarmed_attack_sound = 'sound/weapons/bite.ogg'
unarmed_miss_sound = 'sound/weapons/bite.ogg'
4 changes: 2 additions & 2 deletions code/modules/surgery/bodyparts/parts.dm
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@
aux_layer = BODYPARTS_HIGH_LAYER
body_damage_coeff = LIMB_BODY_DAMAGE_COEFFICIENT_DEFAULT
can_be_disabled = TRUE
unarmed_attack_verb = "punch" /// The classic punch, wonderfully classic and completely random
unarmed_attack_verbs = list("punch") /// The classic punch, wonderfully classic and completely random
grappled_attack_verb = "pummel"
unarmed_damage_low = 5
unarmed_damage_high = 10
@@ -390,7 +390,7 @@
can_be_disabled = TRUE
unarmed_attack_effect = ATTACK_EFFECT_KICK
body_zone = BODY_ZONE_L_LEG
unarmed_attack_verb = "kick" // The lovely kick, typically only accessable by attacking a grouded foe. 1.5 times better than the punch.
unarmed_attack_verbs = list("kick") // The lovely kick, typically only accessable by attacking a grouded foe. 1.5 times better than the punch.
unarmed_damage_low = 7
unarmed_damage_high = 15
unarmed_effectiveness = 15
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@
limb_id = SPECIES_ETHEREAL
dmg_overlay_type = null
attack_type = BURN //burn bish
unarmed_attack_verb = "burn"
unarmed_attack_verbs = list("burn", "singe")
grappled_attack_verb = "scorch"
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
@@ -54,7 +54,7 @@
limb_id = SPECIES_ETHEREAL
dmg_overlay_type = null
attack_type = BURN // bish buzz
unarmed_attack_verb = "burn"
unarmed_attack_verbs = list("burn")
grappled_attack_verb = "scorch"
unarmed_attack_sound = 'sound/weapons/etherealhit.ogg'
unarmed_miss_sound = 'sound/weapons/etherealmiss.ogg'
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
/obj/item/bodypart/arm/left/lizard
icon_greyscale = 'icons/mob/human/species/lizard/bodyparts.dmi'
limb_id = SPECIES_LIZARD
unarmed_attack_verb = "slash"
unarmed_attack_verbs = list("slash", "scratch", "claw")
grappled_attack_verb = "lacerate"
unarmed_attack_effect = ATTACK_EFFECT_CLAW
unarmed_attack_sound = 'sound/weapons/slash.ogg'
@@ -25,7 +25,7 @@
/obj/item/bodypart/arm/right/lizard
icon_greyscale = 'icons/mob/human/species/lizard/bodyparts.dmi'
limb_id = SPECIES_LIZARD
unarmed_attack_verb = "slash"
unarmed_attack_verbs = list("slash", "scratch", "claw")
grappled_attack_verb = "lacerate"
unarmed_attack_effect = ATTACK_EFFECT_CLAW
unarmed_attack_sound = 'sound/weapons/slash.ogg'
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@

/obj/item/bodypart/arm/left/snail
limb_id = SPECIES_SNAIL
unarmed_attack_verb = "slap"
unarmed_attack_verbs = list("slap")
unarmed_attack_effect = ATTACK_EFFECT_DISARM
unarmed_damage_low = 1
unarmed_damage_high = 2 //snails are soft and squishy
@@ -24,7 +24,7 @@

/obj/item/bodypart/arm/right/snail
limb_id = SPECIES_SNAIL
unarmed_attack_verb = "slap"
unarmed_attack_verbs = list("slap")
unarmed_attack_effect = ATTACK_EFFECT_DISARM
unarmed_damage_low = 1
unarmed_damage_high = 2 //snails are soft and squishy
@@ -222,7 +222,7 @@

/obj/item/bodypart/arm/left/pod
limb_id = SPECIES_PODPERSON
unarmed_attack_verb = "slash"
unarmed_attack_verbs = list("slash", "lash")
grappled_attack_verb = "lacerate"
unarmed_attack_effect = ATTACK_EFFECT_CLAW
unarmed_attack_sound = 'sound/weapons/slice.ogg'
@@ -231,7 +231,7 @@

/obj/item/bodypart/arm/right/pod
limb_id = SPECIES_PODPERSON
unarmed_attack_verb = "slash"
unarmed_attack_verbs = list("slash", "lash")
grappled_attack_verb = "lacerate"
unarmed_attack_effect = ATTACK_EFFECT_CLAW
unarmed_attack_sound = 'sound/weapons/slice.ogg'
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@
icon_static = 'icons/mob/human/species/moth/bodyparts.dmi'
limb_id = SPECIES_MOTH
should_draw_greyscale = FALSE
unarmed_attack_verb = "slash"
unarmed_attack_verbs = list("slash")
grappled_attack_verb = "lacerate"
unarmed_attack_effect = ATTACK_EFFECT_CLAW
unarmed_attack_sound = 'sound/weapons/slash.ogg'
@@ -37,7 +37,7 @@
icon_static = 'icons/mob/human/species/moth/bodyparts.dmi'
limb_id = SPECIES_MOTH
should_draw_greyscale = FALSE
unarmed_attack_verb = "slash"
unarmed_attack_verbs = list("slash")
grappled_attack_verb = "lacerate"
unarmed_attack_effect = ATTACK_EFFECT_CLAW
unarmed_attack_sound = 'sound/weapons/slash.ogg'