Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Non-donor colored OOC ckey #1031

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

AyIong
Copy link
Collaborator

@AyIong AyIong commented Jan 20, 2025

Что этот PR делает

Фикс красных ников в чате у НЕ бустеров

Почему это хорошо для игры

Цветной ник вообще должен цениться

Изображения изменений

image

Changelog

🆑
fix: Цветной ckey в OOC теперь не доступен тем, кто не поддержал проект на бусти или не админ. Byond Member тоже имеет цветной ник.
/:cl:

Copy link

sourcery-ai bot commented Jan 20, 2025

Reviewer's Guide by Sourcery

This pull request fixes the issue where non-donors had colored ckeys in OOC chat by adding a condition to check for donor status or unlocked content before applying color.

Sequence diagram for OOC chat ckey color display

sequenceDiagram
    participant Client
    participant ChatSystem
    participant PreferencesSystem

    Client->>ChatSystem: Send OOC message
    ChatSystem->>PreferencesSystem: Check donor status
    alt is donor AND donor_public enabled
        PreferencesSystem-->>ChatSystem: Return colored ckey
    else has unlocked content AND MEMBER_PUBLIC enabled
        PreferencesSystem-->>ChatSystem: Return colored ckey
    else
        PreferencesSystem-->>ChatSystem: Return regular ckey
    end
    ChatSystem-->>Client: Display message with appropriate ckey style
Loading

File-Level Changes

Change Details Files
Fix for colored OOC ckey display for non-donors
  • Added condition to check if the user is a donor or has unlocked content before applying color to ckey.
  • If the user is not a donor or does not have unlocked content, the ckey is displayed without color.
modular_bandastation/chat_badges/code/badges.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🔧 Фикс Перенос бага в другое место. label Jan 20, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 20, 2025
@dj-34 dj-34 merged commit fd39456 into ss220club:master Jan 20, 2025
29 of 31 checks passed
ss220app bot added a commit that referenced this pull request Jan 20, 2025
@AyIong AyIong deleted the fix-plebey-ooc-color branch January 21, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован 🔧 Фикс Перенос бага в другое место.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants