Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove galactic market for rebalancing #1024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larentoun
Copy link
Collaborator

@larentoun larentoun commented Jan 19, 2025

Что этот PR делает

Убран на ребаланс.
Продажи и так сейчас невозможны из-за ТМа, а закупка руды довольно дешевая.

Changelog

🆑
del: Убирает галактическую биржу на ребаланс
/:cl:

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request removes the galactic market from the game for rebalancing purposes. The market is currently unusable due to the trade mechanics and the low cost of ore.

Class diagram showing modified supply pack and market classes

classDiagram
    class supply_pack{
        +special_pod: /obj/structure/closet/supplypod/teleporter
    }
    class materials_market_pack{
        +special: TRUE
    }
    class materials_market{
        +Initialize(mapload)
    }
    supply_pack <|-- materials_market_pack
    note for materials_market "Now self-deletes on map initialization"
    note for materials_market_pack "Disabled for rebalancing"
Loading

Flow diagram showing the removal of galactic market functionality

graph TD
    A[Game Start] --> B{Is Market Initialized?}
    B -->|Yes| C[Delete Market Object]
    B -->|No| D[Market Disabled]
    C --> E[Market Functionality Removed]
    D --> E
    E --> F[Players Must Use<br/>Alternative Methods<br/>for Resources]
Loading

File-Level Changes

Change Details Files
Disabled the materials market supply pack.
  • Added a comment indicating that the market is disabled for rebalancing.
  • Set the 'special' property of the '/datum/supply_pack/imports/materials_market' to TRUE.
modular_bandastation/balance/code/supply_packs.dm
Disabled the initialization of the materials market.
  • Modified the '/obj/machinery/materials_market/Initialize' proc to return 'INITIALIZE_HINT_QDEL' if the map is loading, effectively preventing the market from being initialized.
modular_bandastation/balance/code/supply_packs.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant