forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS only for announcement body #1023
Merged
Gaxeer
merged 11 commits into
ss220club:master
from
AyIong:tts-only-for-announcement-body
Jan 19, 2025
Merged
TTS only for announcement body #1023
Gaxeer
merged 11 commits into
ss220club:master
from
AyIong:tts-only-for-announcement-body
Jan 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThe pull request modifies the text-to-speech (TTS) functionality to only read the announcement body, instead of the entire announcement string. This change was made by adding a new parameter to the dispatch_announcement_to_players proc and passing the announcement text to the TTS subsystem. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Gaxeer
reviewed
Jan 19, 2025
Co-authored-by: Gaxeer <[email protected]>
…yIong/TG220 into tts-only-for-announcement-body
AyIong
commented
Jan 19, 2025
Gaxeer
approved these changes
Jan 19, 2025
dj-34
requested changes
Jan 19, 2025
dj-34
requested changes
Jan 19, 2025
Co-authored-by: dj-34 <[email protected]>
dj-34
approved these changes
Jan 19, 2025
AyIong
added
the
🛑 Do Not Merge
Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это!
label
Jan 19, 2025
AyIong
force-pushed
the
tts-only-for-announcement-body
branch
from
January 19, 2025 20:36
81a9200
to
b5d601d
Compare
AyIong
force-pushed
the
tts-only-for-announcement-body
branch
from
January 19, 2025 21:08
4e8d637
to
5c082ea
Compare
AyIong
removed
📝 Перевод
Фаргус® Полностью на русском языке
🛑 Do Not Merge
Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это!
labels
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
ТТС теперь должен озвучивать только текст анонса, а не от кого анонс, какой тип анонса и в честь чего анонс
Почему это хорошо для игры
ТТС меньше тараторит из-за отсутствия знаков препинания у вышеперечисленного говна
Тестирование
Надеюсь работает :clueless:
Changelog
🆑
qol: ТТС теперь озвучивает только текст оповещения, а не всё подряд в оповещении
fix: Анонсы через реквест консоль, теперь говорят голосом анонсирующего
/:cl:
Summary by Sourcery
Send only the announcement text to the text-to-speech (TTS) system, rather than the entire announcement message. This improves the TTS output by reducing unnecessary chatter.
New Features:
Tests: