Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS only for announcement body #1023

Merged
merged 11 commits into from
Jan 19, 2025

Conversation

AyIong
Copy link
Collaborator

@AyIong AyIong commented Jan 19, 2025

Что этот PR делает

ТТС теперь должен озвучивать только текст анонса, а не от кого анонс, какой тип анонса и в честь чего анонс

Почему это хорошо для игры

ТТС меньше тараторит из-за отсутствия знаков препинания у вышеперечисленного говна

Тестирование

Надеюсь работает :clueless:

Changelog

🆑
qol: ТТС теперь озвучивает только текст оповещения, а не всё подряд в оповещении
fix: Анонсы через реквест консоль, теперь говорят голосом анонсирующего
/:cl:

Summary by Sourcery

Send only the announcement text to the text-to-speech (TTS) system, rather than the entire announcement message. This improves the TTS output by reducing unnecessary chatter.

New Features:

  • Added a feature to send only the body of announcements to the TTS system.

Tests:

  • Tested the changes to ensure the TTS system only receives the announcement text.

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

The pull request modifies the text-to-speech (TTS) functionality to only read the announcement body, instead of the entire announcement string. This change was made by adding a new parameter to the dispatch_announcement_to_players proc and passing the announcement text to the TTS subsystem.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the dispatch_announcement_to_players proc to accept a tts_message parameter.
  • Added a tts_message parameter to the dispatch_announcement_to_players proc.
  • Passed the announcement text to the TTS subsystem using the new tts_message parameter.
code/__HELPERS/priority_announce.dm
Modified the call to dispatch_announcement_to_players to include the announcement text as the tts_message.
  • Added the tts_message parameter to the call to dispatch_announcement_to_players, passing the announcement text.
code/__HELPERS/priority_announce.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 19, 2025
code/__HELPERS/priority_announce.dm Outdated Show resolved Hide resolved
code/__HELPERS/priority_announce.dm Outdated Show resolved Hide resolved
code/__HELPERS/priority_announce.dm Show resolved Hide resolved
code/__HELPERS/priority_announce.dm Outdated Show resolved Hide resolved
@AyIong AyIong requested a review from dj-34 January 19, 2025 17:37
@AyIong AyIong changed the base branch from master to translate January 19, 2025 18:03
@AyIong AyIong added the 🛑 Do Not Merge Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это! label Jan 19, 2025
@github-actions github-actions bot added the 📝 Перевод Фаргус® Полностью на русском языке label Jan 19, 2025
@AyIong AyIong force-pushed the tts-only-for-announcement-body branch from 81a9200 to b5d601d Compare January 19, 2025 20:36
@AyIong AyIong force-pushed the tts-only-for-announcement-body branch from 4e8d637 to 5c082ea Compare January 19, 2025 21:08
@AyIong AyIong changed the base branch from translate to master January 19, 2025 21:09
@AyIong AyIong removed 📝 Перевод Фаргус® Полностью на русском языке 🛑 Do Not Merge Почему это висит лучше уточнить в дискорде. 220 проклятий тому кто зальёт это! labels Jan 19, 2025
@Gaxeer Gaxeer merged commit 3e4181e into ss220club:master Jan 19, 2025
7 checks passed
ss220app bot added a commit that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants