Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR & BlueShiled access fix #1020

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

konushi
Copy link

@konushi konushi commented Jan 19, 2025

Что этот PR делает

Попытка номер два.

Представителю и Щиту добавлены доступы в прямые точки их интереса - кабинеты глав. Пока что только на Кибериаде.
Наушник Представителя теперь ловит радиочастоты всех отделов.
Небольшой фикс кнопочки в кофейне на Кибериаде - был не привязан id.

Почему это хорошо для игры

НТР есть заноза в задница

Изображения изменений

Локалка, работает

Тестирование

Changelog

🆑
fix: НТР и БЩ теперь имеют доступы в кабинеты глав на Кибериаде. НТР имеет доступ ко всем радиочастотам станции. Фикс кнопки в кофейне Кибериады.
/:cl:

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request grants Nanotrasen Representatives and Blueshield access to the heads' offices on Cyberiad. Additionally, the Representative's headset can now receive all department radio channels. A minor fix was also implemented for a button in the Cyberiad coffee shop.

Class diagram showing changes to encryption key

classDiagram
    class EncryptionKeyNTRep {
        name: string
        icon_state: string
        channels: list
        greyscale_config: datum
        greyscale_colors: string
    }
    note for EncryptionKeyNTRep "Modified channels list to include all department frequencies"
Loading

File-Level Changes

Change Details Files
Added access for Nanotrasen Representatives and Blueshield to the heads' offices on Cyberiad.
  • Added access to the heads' offices for Nanotrasen Representatives and Blueshield on Cyberiad map
_maps/map_files/Cyberiad/Cyberiad.dmm
The Nanotrasen Representative's headset can now receive all department radio channels.
  • Added all department radio channels to the Nanotrasen Representative's encryption key
modular_bandastation/objects/code/items/devices/radio.dm
Fixed a button in the Cyberiad coffee shop.
  • Fixed a button in the Cyberiad coffee shop
_maps/map_files/Cyberiad/Cyberiad.dmm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@konushi konushi changed the title NTR & BlueShied access fix NTR & BlueShiled access fix Jan 19, 2025
@github-actions github-actions bot added the 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один. label Jan 19, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 19, 2025
@Gaxeer Gaxeer merged commit a5a6948 into ss220club:master Jan 19, 2025
31 of 33 checks passed
ss220app bot added a commit that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants