Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify module creation #1019

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Simplify module creation #1019

merged 4 commits into from
Jan 19, 2025

Conversation

AyIong
Copy link
Collaborator

@AyIong AyIong commented Jan 19, 2025

Что этот PR делает

Упрощение создания модуля. По сути то что делал фуриор на пару, но с некоторыми улучшениями (Спасибо чатгпт xdd)

  • Модуль автоматом инклюдится в корневой .dme, при этом все инклюды модулей сортируются в алфавитном порядке
  • В папке модуля создаётся папка icons
  • В датуме модуля, фуриор заменяется на имя папки юзера

Тестирование

Я заебался удалять тестовые папки

Summary by Sourcery

New Features:

  • Add a script to simplify the creation of new modules for the project.

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request introduces a script to simplify the creation of new modules. The script automates the process of creating a new module, including adding the module to the root .dme file, creating an icons folder, and replacing the 'furior' placeholder with the user's directory name.

Flow diagram for module creation script

flowchart TD
    Start([Start]) --> Input[/Get module name from user/]
    Input --> CreateDir[Create module directory structure]
    CreateDir --> CopyFiles[Copy example files]
    CopyFiles --> RenameFiles[Rename files with module name]
    RenameFiles --> CreateIcons[Create icons directory]
    CreateIcons --> UpdateContent[Update content in module files]
    UpdateContent --> UpdateDME[Update root .dme file]
    UpdateDME --> SortIncludes[Sort module includes alphabetically]
    SortIncludes --> End([End])

    subgraph UpdateContent
        direction TB
        Replace1[Replace 'Example modpack' text] --> Replace2[Replace 'example' references]
        Replace2 --> Replace3[Replace 'furior' with username]
    end
Loading

File-Level Changes

Change Details Files
Introduced a script to automate module creation.
  • Copies an example module folder to a new module folder.
  • Renames files within the new module folder to match the module name.
  • Creates an 'icons' directory within the new module folder.
  • Replaces placeholders in the module's .dm and .dme files with the module name.
  • Replaces the 'furior' placeholder in the module's .dm file with the user's directory name.
  • Adds the new module's .dme include to the root .dme file, sorting all module includes alphabetically.
modular_bandastation/create_modpack.bat
Modified the root .dme file to include module includes.
  • Added comments to mark the start and end of the module includes section.
modular_bandastation/modular_bandastation.dme

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AyIong AyIong marked this pull request as ready for review January 19, 2025 13:16
@ss220app ss220app bot added the 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется label Jan 19, 2025
@AyIong AyIong added 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать and removed 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется labels Jan 19, 2025
@Gaxeer Gaxeer merged commit 47e4f35 into ss220club:master Jan 19, 2025
25 of 32 checks passed
@AyIong AyIong deleted the chatgpt-+-furior branch January 21, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants