Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR & BlueShield access fix #1013

Closed
wants to merge 9 commits into from

Conversation

konushi
Copy link

@konushi konushi commented Jan 18, 2025

Что этот PR делает

Представителю и Щиту добавлены доступы в прямые точки их интереса - кабинеты глав. Пока что только на Кибериаде.
Наушник Представителя теперь ловит радиочастоты всех отделов.
Небольшой фикс кнопочки в кофейне на Кибериаде - не привязан id.

Почему это хорошо для игры

НТР есть заноза в задница

Изображения изменений

Тестирование

Локалка

Changelog

🆑
fix: НТР и БЩ теперь имеют доступы в кабинеты глав на Кибериаде. НТР имеет доступ ко всем радиочастотам станции. Фикс кнопки в кофейне Кибериады.
/:cl:

Copy link

sourcery-ai bot commented Jan 18, 2025

Reviewer's Guide by Sourcery

This pull request implements access changes for the Nanotrasen Representative and Blueshield, granting them access to the heads' offices. Additionally, the Nanotrasen Representative's headset now receives all department radio frequencies. A minor fix was also applied to a button in the Cyberiad coffee shop.

Class diagram showing updated encryption key configuration

classDiagram
    class EncryptionKey {
        +name: string
        +icon_state: string
        +channels: list
        +greyscale_config
        +greyscale_colors: string
    }
    class NTRepEncryptionKey {
        +name: "nanotrasen representative's encryption key"
        +icon_state: "cypherkey_centcom"
        +channels: list[all departments]
        +greyscale_config: "/datum/greyscale_config/encryptionkey_centcom"
        +greyscale_colors: "#1d2657#dca01b"
    }
    EncryptionKey <|-- NTRepEncryptionKey
    note for NTRepEncryptionKey "Updated to include all department channels"
Loading

File-Level Changes

Change Details Files
The Nanotrasen Representative's encryption key now has access to all radio channels.
  • Added all department radio channels to the Nanotrasen Representative's encryption key.
modular_bandastation/objects/code/items/devices/radio.dm
A button in the Cyberiad coffee shop was fixed.
  • Fixed a button in the Cyberiad coffee shop.
_maps/map_files/Cyberiad/Cyberiad.dmm

Possibly linked issues

  • #0: The PR directly addresses the issue by granting BlueShield access to head offices.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один. label Jan 18, 2025
@ss220app ss220app bot added 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется 📜 CL валиден Этот чейнджлог будет успешно опубликован and removed 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется labels Jan 18, 2025
@konushi konushi marked this pull request as draft January 18, 2025 12:41
@konushi
Copy link
Author

konushi commented Jan 18, 2025

вечером или завтра уберу немодульные изменения

@konushi konushi marked this pull request as ready for review January 19, 2025 10:35
@konushi
Copy link
Author

konushi commented Jan 19, 2025

немного криво решил конфликты, но вроде от мастера не отличается

@konushi
Copy link
Author

konushi commented Jan 19, 2025

Наебал

…hield_access"

This reverts commit 1a9417c, reversing
changes made to b03645e.
@github-actions github-actions bot added the 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! label Jan 19, 2025
@konushi
Copy link
Author

konushi commented Jan 19, 2025

короче сделаем проще

@konushi konushi closed this Jan 19, 2025
@konushi konushi deleted the ntr_blueshield_access branch January 19, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! 📜 CL валиден Этот чейнджлог будет успешно опубликован 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant