forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add announcement tts effect, sync pre sfx, tts and post sfx #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new sound effect for TTS announcements and synchronizes pre and post sound effects with the TTS audio. Sequence diagram for synchronized announcement sound playbacksequenceDiagram
participant A as Announcement System
participant TTS as TTS Subsystem
participant SFX as Sound Effects
participant L as Listener
A->>TTS: Play announcement
Note over TTS: Apply announcement effect
TTS->>SFX: Play pre-SFX (synchronized)
TTS->>L: Play TTS audio
TTS->>SFX: Play post-SFX (synchronized)
Class diagram for sound effect system changesclassDiagram
class sound_effect {
+bool complex
+string suffix
+string ffmpeg_arguments
}
class announcement_effect {
+bool complex = true
+string suffix = "_announcement"
+string ffmpeg_arguments
}
sound_effect <|-- announcement_effect
note for announcement_effect "New effect with complex
FFmpeg processing for
announcements"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Furrior
reviewed
Jan 17, 2025
…tion into announce-effect-tts
dj-34
reviewed
Jan 19, 2025
Gaxeer
commented
Jan 19, 2025
Gaxeer
commented
Jan 19, 2025
dj-34
approved these changes
Jan 19, 2025
Gaxeer
commented
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Добавляет новый эффект для ТТСа оповещений
Синхронизирует preSXF и postSFX с ТТСом
Почему это хорошо для игры
Атмосферный эффект оповещение и отсутствия наложения звука оповещений
Changelog
🆑
add: Добавляет новый эффект для ТТСа оповещений
fix: preSXF и postSFX теперь синхронизируются с ТТСом
/:cl:
Summary by Sourcery
Add a new announcement TTS effect and synchronize pre, TTS, and post sound effects.
New Features:
Tests: