Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add announcement tts effect, sync pre sfx, tts and post sfx #1011

Merged
merged 22 commits into from
Jan 19, 2025

Conversation

Gaxeer
Copy link
Collaborator

@Gaxeer Gaxeer commented Jan 17, 2025

Что этот PR делает

Добавляет новый эффект для ТТСа оповещений
Синхронизирует preSXF и postSFX с ТТСом

Почему это хорошо для игры

Атмосферный эффект оповещение и отсутствия наложения звука оповещений

Changelog

🆑
add: Добавляет новый эффект для ТТСа оповещений
fix: preSXF и postSFX теперь синхронизируются с ТТСом
/:cl:

Summary by Sourcery

Add a new announcement TTS effect and synchronize pre, TTS, and post sound effects.

New Features:

  • Added a new "announcement" sound effect for TTS, which includes reverb, filtering, and dynamic range compression, creating a more atmospheric and immersive experience for announcements.

Tests:

  • Ensured the new announcement sound effect is used for priority announcements.

Copy link

sourcery-ai bot commented Jan 17, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new sound effect for TTS announcements and synchronizes pre and post sound effects with the TTS audio.

Sequence diagram for synchronized announcement sound playback

sequenceDiagram
    participant A as Announcement System
    participant TTS as TTS Subsystem
    participant SFX as Sound Effects
    participant L as Listener

    A->>TTS: Play announcement
    Note over TTS: Apply announcement effect
    TTS->>SFX: Play pre-SFX (synchronized)
    TTS->>L: Play TTS audio
    TTS->>SFX: Play post-SFX (synchronized)
Loading

Class diagram for sound effect system changes

classDiagram
    class sound_effect {
        +bool complex
        +string suffix
        +string ffmpeg_arguments
    }

    class announcement_effect {
        +bool complex = true
        +string suffix = "_announcement"
        +string ffmpeg_arguments
    }

    sound_effect <|-- announcement_effect

    note for announcement_effect "New effect with complex
FFmpeg processing for
announcements"
Loading

File-Level Changes

Change Details Files
Added a new 'announcement' sound effect with complex audio processing.
  • Introduced a new sound effect type with a complex flag.
  • Added a new 'announcement' sound effect with specific audio filters.
  • Modified the ffmpeg command to handle complex sound effects.
  • Added logic to bypass other filters if a complex filter is present.
modular_bandastation/tts/code/shell.dm
Synchronized pre and post sound effects with TTS audio.
  • Modified the TTS subsystem to handle complex sound effects.
  • Modified the TTS subsystem to pass the channel to the play_sfx function.
  • Modified the play_sfx function to accept a channel parameter.
  • Modified the priority announce helper to use the new announcement sound effect.
modular_bandastation/tts/code/tts_subsystem.dm
code/__HELPERS/priority_announce.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 17, 2025
modular_bandastation/tts/code/SSHttp.dm Outdated Show resolved Hide resolved
modular_bandastation/tts/code/SSHttp.dm Outdated Show resolved Hide resolved
@Gaxeer Gaxeer merged commit 4ffa797 into ss220club:master Jan 19, 2025
22 of 24 checks passed
ss220app bot added a commit that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants