Skip to content

Commit

Permalink
Combined soundadd/sounddel and imageadd/imagedel (tgstation#74865)
Browse files Browse the repository at this point in the history
## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog. 

I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.

---------

Co-authored-by: tattle <[email protected]>
  • Loading branch information
dragomagol and tattle authored Apr 21, 2023
1 parent c09eb15 commit aeed75d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 38 deletions.
6 changes: 2 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
sound: added/modified/removed audio or sound effects
image: added/modified/removed some icons or images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
Expand Down
20 changes: 4 additions & 16 deletions tools/WebhookProcessor/github_webhook_processor.php
Original file line number Diff line number Diff line change
Expand Up @@ -705,17 +705,11 @@ function checkchangelog($payload) {
$tags[] = 'Quality of Life';
}
break;
case 'soundadd':
if($item != 'added a new sound thingy') {
case 'sound':
if($item != 'added/modified/removed audio or sound effects') {
$tags[] = 'Sound';
}
break;
case 'sounddel':
if($item != 'removed an old sound thingy') {
$tags[] = 'Sound';
$tags[] = 'Removal';
}
break;
case 'add':
case 'adds':
case 'rscadd':
Expand All @@ -730,17 +724,11 @@ function checkchangelog($payload) {
$tags[] = 'Removal';
}
break;
case 'imageadd':
if($item != 'added some icons and images') {
case 'image':
if($item != 'added/modified/removed some icons or images') {
$tags[] = 'Sprites';
}
break;
case 'imagedel':
if($item != 'deleted some icons and images') {
$tags[] = 'Sprites';
$tags[] = 'Removal';
}
break;
case 'typo':
case 'spellcheck':
if($item != 'fixed a few typos') {
Expand Down
22 changes: 4 additions & 18 deletions tools/pull_request_hooks/changelogConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,30 +40,16 @@ export const CHANGELOG_ENTRIES = [
],

[
["soundadd"],
["sound"],
{
placeholders: ["added a new sound thingy"],
placeholders: ["added/modified/removed audio or sound effects"],
},
],

[
["sounddel"],
["image"],
{
placeholders: ["removed an old sound thingy"],
},
],

[
["imageadd"],
{
placeholders: ["added some icons and images"],
},
],

[
["imagedel"],
{
placeholders: ["deleted some icons and images"],
placeholders: ["added/modified/removed some icons or images"],
},
],

Expand Down

0 comments on commit aeed75d

Please sign in to comment.