forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 56
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes Badges Being Broken in the README (tgstation#77718)
## About The Pull Request This shit was broken:  Ew, the alt text is bad too. Anyways, this is because the badge servicer we use has been down for the last two weeks, as detailed in forthebadge/for-the-badge#252. There is no ETA on getting the service back up, and I was able to use the trick detailed in that issue in order to grab the SVGs of those images and then move those to a folder in our repository, and then have the readme pull it from there. **This has been stated to be okay by the project in their repository's readme** btw, but I included an attributions page in the new folder I made. Much nicer to no longer have that external dependency. I also cleaned up some other code (tied up the alt text, made the coverage more accurate, etc. etc.). I'm not sure if it's worthwhile to also selfhost the comic links (as well as potentially running awry of CC 3.0 regulations), but I think this much is fine for now. You can see an example of this working here: https://github.com/san7890/bruhstation/tree/readers#readme I don't know if the service will ever come back again, but given that it's been two weeks, I'm not really much willing to wait it out. Self-hosting this stuff is poggers anyhow ## Changelog Not Applicable
- Loading branch information
Showing
7 changed files
with
72 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Attributions | ||
|
||
## Badges | ||
`built-with-resentment.svg` and `contains-technical-debt.svg` were originally sourced from https://forthebadge.com/, with the repository located at https://github.com/BraveUX/for-the-badge. `made-in-byond.gif` is a user-generated modification of one of these badges provided by this service. | ||
|
||
## Comics | ||
|
||
Both comics are sourced from https://www.monkeyuser.com/, which gives permission for use in non-profit usage via https://www.monkeyuser.com/about/index.html. `bug_free.png` can be found at https://www.monkeyuser.com/2019/bug-free/, and the original version of `technical_debt.png` can be found at https://www.monkeyuser.com/2018/tech-debt/ (the version found in the folder has been modified). |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters