Skip to content

Commit

Permalink
0043656: SCORM-Player is flooding the logs (ILIAS-eLearning#8920)
Browse files Browse the repository at this point in the history
* 42276 - SCORM HTTP context

https://mantis.ilias.de/view.php?id=42276

* Strict types error fixed

_getMaxScoreForUser returns float value or null
https://mantis.ilias.de/view.php?id=43296

* Type error fixed

https://support.iliasnet.de/view.php?id=9387
Type error fixed, returning string only

* Type error fixed

https://support.iliasnet.de/view.php?id=9387
Type error fixed, returning string only

* 0043656: SCORM-Player is flooding the logs

Intercept json_decode returning null, causing log messages.
https://mantis.ilias.de/view.php?id=43656
  • Loading branch information
qualitus-dahme authored Jan 29, 2025
1 parent 4443792 commit 5fd5b94
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,8 @@ public function writeSharedData(int $sco_node_id): void
$ilUser = $DIC->user();
$g_data = json_decode(file_get_contents('php://input'));

if ($g_data == null) return;

//Step 1: Get the writeable stores for this SCO that already have values
$query = 'SELECT dm.target_id, sd.store '
. 'FROM cp_datamap dm '
Expand Down

0 comments on commit 5fd5b94

Please sign in to comment.