Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent nix-health info from printing to stdout; add integration test #81

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

shivaraj-bh
Copy link
Contributor

@shivaraj-bh shivaraj-bh commented Jul 12, 2024

Mark PR ready for review once juspay/nix-health#28 is finalized

resolves #79

@shivaraj-bh shivaraj-bh changed the title fix: Do not print nix-health info on stdout; Add integration test to avoid polluting stdout fix: Prevent nix-health info from printing to stdout; add integration test Jul 12, 2024
tests/integration_test.rs Outdated Show resolved Hide resolved
@shivaraj-bh shivaraj-bh marked this pull request as ready for review July 12, 2024 08:11
@sinrohit
Copy link
Contributor

@shivaraj-bh nixci build fails for this PR.

Copy link
Contributor

@sinrohit sinrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the nix-health reference? tracing branch does not exists now.

@srid
Copy link
Owner

srid commented Jul 12, 2024

By the way, since this fix commit fixes an unreleased changed, I'm going to drop fix from commit prefix because I don't want it to appear in the ChangeLog.

(Is there an appropriate prefix for this?)

@srid srid merged commit 597bf34 into srid:master Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdout is no longer a list of paths built
3 participants