Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Note from plainify output #3

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

TristanCacqueray
Copy link
Contributor

@TristanCacqueray TristanCacqueray commented Mar 25, 2024

See: srid/emanote#529

TODO(@srid)

  • Add tests (Add tests #1) in master branch
  • Add plainify tests in this PR
  • Refactor

@srid
Copy link
Owner

srid commented Mar 25, 2024

I'll try to initialize some tests (#1) in the master branch. Then, we can add tests for this change before merging it.

@srid
Copy link
Owner

srid commented Mar 25, 2024

I noticed that plainify'ication of regular links are broken, hence that test is disabled. Let's address this in different PR.

@srid srid merged commit 57dcf66 into srid:master Mar 25, 2024
1 check passed
@srid
Copy link
Owner

srid commented Mar 25, 2024

May need follow-up fix for srid/emanote#529 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants