This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
CA-16/Fix floor plan crash #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danybony
approved these changes
Jan 1, 2017
| @Override | ||
| public void onDataUpdated(List<Integer> requestIds) { | ||
| @Override | ||
| public void onStart() { |
There was a problem hiding this comment.
Move this after onCreateView to follow the lifecycle
| private class LoadPlansTask extends AsyncTask<Void, Void, List<FloorPlan>> { | ||
| private static class LoadPlansTask extends AsyncTask<Void, Void, List<FloorPlan>> { | ||
|
|
||
| private final LoadPlansTaskCallback callback; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses lemberg/connfa-android#16. It's another NPE, where a failing network request yields a null image source and then crashes the app. This PR includes the same kind of cleanup #19 contained, too. See commits for more details.