Update CredentialPack to use ParsedCredential #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobward
requested review from
rschulman,
Ryanmtate,
Juliano1612 and
Joey-Silberman
rschulman
reviewed
Oct 3, 2024
| } | ||
| } | ||
|
|
||
| /// Get a credential by id. | ||
| public func get(credentialId: Uuid) -> ParsedCredential? { |
There was a problem hiding this comment.
I'm a bit weirded out by having two functions with the same name and just an argument name that differs by one letter, but that might also just be a Swift convention, and I don't know Swift that well.
There was a problem hiding this comment.
I think this is a fairly normal Swift convention, but maybe @todd-spruceid or @Juliano1612 can weigh in.
There was a problem hiding this comment.
Yeah, that's common. You only can't have multiple methods with the same signature.
rschulman
approved these changes
Oct 3, 2024
Juliano1612
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
LGTM! Started this spruceid/mobile-sdk-ios-app#20 PR to make the demo app compatible with these changes
cobward
deleted the
skit-572-update-credentialpack-to-use-parsedcredential-swift
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.