Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix erc20Approvals #311

Merged
merged 4 commits into from
Nov 13, 2023
Merged

fix: fix erc20Approvals #311

merged 4 commits into from
Nov 13, 2023

Conversation

tcar121293
Copy link
Contributor

fix erc20Approvals

Description

remove dynamic fee handler type and use percentage type

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293 tcar121293 merged commit 68ac851 into main Nov 13, 2023
3 checks passed
@tcar121293 tcar121293 deleted the tcar/fix-erc20-approvals branch November 13, 2023 14:11
tcar121293 added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants