Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extended regex for replace_text. #215

Closed
wants to merge 2 commits into from
Closed

Use extended regex for replace_text. #215

wants to merge 2 commits into from

Conversation

weakish
Copy link
Contributor

@weakish weakish commented May 3, 2016

Previously it used basic regex.

@joshgoebel
Copy link
Contributor

Please split out npm change.

Change to replace text would need to be some type of option because as is it would be potentially breaking change.

@weakish
Copy link
Contributor Author

weakish commented May 6, 2016

Please split out npm change.

Sorry. 8dfd022 is identical to 572f4b6 (already included in #216).
I checked in wrong files.

it would be potentially breaking change.

👍

Close this pull request now.
I will add a option to replace_text and file_contains for specifying regex type,
and open a new pull-request.

@weakish weakish closed this May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weakish @joshgoebel