Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the BeanDefinitionNames constant interface to a final class Constant class that cannot be inherited. #3215

Closed
wants to merge 1 commit into from
Closed

Change the BeanDefinitionNames constant interface to a final class Constant class that cannot be inherited. #3215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ain/java/org/springframework/data/jpa/repository/config/AuditingBeanDefinitionParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
package org.springframework.data.jpa.repository.config;

import static org.springframework.beans.factory.support.BeanDefinitionBuilder.*;

import static org.springframework.data.jpa.repository.config.BeanDefinitionNames.*;
import org.springframework.beans.factory.config.BeanDefinition;
import org.springframework.beans.factory.parsing.BeanComponentDefinition;
import org.springframework.beans.factory.support.AbstractBeanDefinition;
Expand All @@ -41,7 +41,7 @@ public class AuditingBeanDefinitionParser implements BeanDefinitionParser {
private static final String AUDITING_BFPP_CLASS_NAME = "org.springframework.data.jpa.domain.support.AuditingBeanFactoryPostProcessor";

private final AuditingHandlerBeanDefinitionParser auditingHandlerParser = new AuditingHandlerBeanDefinitionParser(
BeanDefinitionNames.JPA_MAPPING_CONTEXT_BEAN_NAME);
JPA_MAPPING_CONTEXT_BEAN_NAME);
private final SpringConfiguredBeanDefinitionParser springConfiguredParser = new SpringConfiguredBeanDefinitionParser();

@Override
Expand Down
10 changes: 6 additions & 4 deletions ...jpa/src/main/java/org/springframework/data/jpa/repository/config/BeanDefinitionNames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
* @author Thomas Darimont
* @author Andrew Walters
*/
interface BeanDefinitionNames {
public final class BeanDefinitionNames {

String JPA_MAPPING_CONTEXT_BEAN_NAME = "jpaMappingContext";
String JPA_CONTEXT_BEAN_NAME = "jpaContext";
String EM_BEAN_DEFINITION_REGISTRAR_POST_PROCESSOR_BEAN_NAME = "emBeanDefinitionRegistrarPostProcessor";
private BeanDefinitionNames() {}

static final String JPA_MAPPING_CONTEXT_BEAN_NAME = "jpaMappingContext";
static final String JPA_CONTEXT_BEAN_NAME = "jpaContext";
static final String EM_BEAN_DEFINITION_REGISTRAR_POST_PROCESSOR_BEAN_NAME = "emBeanDefinitionRegistrarPostProcessor";
}