Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polishing #3452

Closed
wants to merge 1 commit into from
Closed

Polishing #3452

wants to merge 1 commit into from
+4 −5

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Apr 28, 2024

  1. Specification should be annotated with @FunctionalInterface
  2. SpecificationUnitTests shouldn't be Serializable

@quaff
Polishing
69cb493 
1. `Specification` should be annotated with `@FunctionalInterface`
2. `SpecificationUnitTests` shouldn't be `Serializable`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2024
@mp911de mp911de self-assigned this Apr 29, 2024
@mp911de mp911de added the status: on-hold We cannot start working on this issue yet label Jun 10, 2024
@mp911de
Copy link
Member

mp911de commented Jun 10, 2024

Putting this on hold as we need to overhaul the Specification infrastructure before adding more changes to it.

@mp911de mp911de force-pushed the main branch 2 times, most recently from 52ee55f to 61e6d36 Compare October 9, 2024 07:35
@mp911de mp911de added type: task A general task and removed status: on-hold We cannot start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Jan 31, 2025
@mp911de mp911de added this to the 3.4.3 (2024.1.3) milestone Jan 31, 2025
mp911de pushed a commit that referenced this pull request Jan 31, 2025
@quaff @mp911de
Polishing.
b0d5c2c 
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
mp911de added a commit that referenced this pull request Jan 31, 2025
@mp911de
Polishing.
70dcc34 
Refine deprecation warnings.

See #3452
@mp911de mp911de closed this in aea1a03 Jan 31, 2025
mp911de added a commit that referenced this pull request Jan 31, 2025
@mp911de
Polishing.
4db0ac2 
Refine deprecation warnings.

See #3452
mp911de pushed a commit that referenced this pull request Jan 31, 2025
@quaff @mp911de
Polishing.
241a466 
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
@mp911de
Copy link
Member

mp911de commented Jan 31, 2025

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
3.4.3 (2024.1.3)
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @mp911de @spring-projects-issues