Polishing.

Add missing `@FunctionalInterface` to Specification interfaces. `SpecificationUnitTests` shouldn't be `Serializable`. Closes #3452
spring-projects · Jan 31, 2025 · aea1a03 · aea1a03
1 parent cd12bd5
commit aea1a03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/domain/Specification.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/domain/Specification.java
@@ -39,6 +39,7 @@
  * @author Daniel Shuy
  * @author Sergey Rukin
  */
+@FunctionalInterface
 public interface Specification<T> extends Serializable {
 
 	@Serial long serialVersionUID = 1L;

diff --git a/...ng-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java b/...ng-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java
@@ -46,10 +46,9 @@
  * @author Mark Paluch
  * @author Daniel Shuy
  */
-@SuppressWarnings("serial")
 @ExtendWith(MockitoExtension.class)
 @MockitoSettings(strictness = Strictness.LENIENT)
-class SpecificationUnitTests implements Serializable {
+class SpecificationUnitTests {
 
 	private Specification<Object> spec;
 	@Mock(serializable = true) Root<Object> root;
@@ -163,7 +162,7 @@ void specificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings("unchecked")
+		@SuppressWarnings({"unchecked", "deprecation"})
 		Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
 
 		assertThat(transferredSpecification).isNotNull();
@@ -178,7 +177,7 @@ void complexSpecificationsShouldBeSerializable() {
 
 		assertThat(specification).isNotNull();
 
-		@SuppressWarnings("unchecked")
+		@SuppressWarnings({"unchecked", "deprecation"})
 		Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
 
 		assertThat(transferredSpecification).isNotNull();