Skip to content

Commit

Permalink
Add test for derived finder method using unpaged with sort.
Browse files Browse the repository at this point in the history
  • Loading branch information
christophstrobl committed Jul 4, 2024
1 parent 38a11d0 commit a5a2ae7
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -2888,16 +2889,27 @@ void existsByExampleNegative() {
}

@Test // GH-3476
void unPagedSortedQuery() {
void findAllUsingUnpagePageableWithSort() {

flushTestUsers();

Sort sort = Sort.by(DESC, "firstname");
Page<User> firstPage = repository.findAll(PageRequest.of(0, 10, sort));
Page<User> secondPage = repository.findAll(Pageable.unpaged(sort));
assertThat(firstPage.getContent()).isEqualTo(secondPage.getContent());
assertThat(firstPage.getContent()).containsExactlyElementsOf(secondPage.getContent());
}

@Test // GH-3476
void derivedFinderUsingUnpagedPageableWithSort() {

flushTestUsers();

List<User> sortedUsers = new ArrayList<>(List.of(firstUser, secondUser, thirdUser, fourthUser));
sortedUsers.sort(Comparator.comparing(User::getEmailAddress));

assertThat(repository.findByEmailAddressLike("%@%", Pageable.unpaged(Sort.by(Direction.ASC, "lastname"))))
.containsExactlyElementsOf(sortedUsers);
}

@Test // DATAJPA-905
void executesPagedSpecificationSettingAnOrder() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ Window<User> findTop3ByFirstnameStartingWithOrderByFirstnameAscEmailAddressAsc(S

List<User> findByEmailAddressLike(String email, Sort sort);

List<User> findByEmailAddressLike(String email, Pageable pageable);

List<SpecialUser> findSpecialUsersByLastname(String lastname);

List<User> findBySpringDataNamedQuery(String lastname);
Expand Down

0 comments on commit a5a2ae7

Please sign in to comment.