Enable tests #1834
Closed
Enable tests #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure Renovate
wind57
commented
Jan 14, 2025
| @@ -94,8 +93,6 @@ static void beforeAll() { | |||
| * - second polling cycle reads sources from k8s and finds a change | |||
| * </pre> | |||
| */ | |||
| @DisabledIfEnvironmentVariable(named = "JENKINS_HOME", matches = "^(?=\\s*\\S).*$", | |||
There was a problem hiding this comment.
this and all other that have the @DisabledIfEnvironmentVariable annotation were fixed recently, so I think we should remove this now
wind57
commented
Jan 14, 2025
| @@ -100,7 +99,6 @@ void afterEach() { | |||
| configWatcher(Phase.DELETE); | |||
| } | |||
|
|
|||
| @Disabled | |||
There was a problem hiding this comment.
I don't know why this one was disabled and the next one too, but I am enabling them back. release was done and we have time now to figure out why they fail, if at all.
|
@ryanjbaxter this is ready to be looked at. It just enables some tests that were disabled before. Thank you |
|
Need too address the failures from #1833 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.