Refactor last fabric8 integration test package (1) #1824
Conversation
|
@ryanjbaxter this refactors the last fabric8 package in integration tests. As usual, I have not changed the scenarios at all, just refactored and removed overlapping tests. Thank you |
|
Thanks! I am on vacation until January 6th, I will take a look when I get back |
wind57
changed the title
| secrets: | ||
| enabled: true | ||
| enable-api: true | ||
|
|
||
| # otherwise we can't refresh in the test | ||
| main: |
There was a problem hiding this comment.
If you didn't change the tests I am curious as to why we need to add this now?
There was a problem hiding this comment.
good eye! as usual :) so this has eaten the most of the time when I refactored this one. Initially, this property exists in the @TestPropertySource, but after I refresh, this one is "lost". In the previous test we used to shutdown and now we refresh (shutdown would not work with this kind of refactor). Since it is lost, the test would fail, thus I need it "again", after the refresh is called. I hope it makes sense
|
And this should only go into main? I thought the others went into 3.1.x as well |
|
you're right, my bad. changed to |
No description provided.