Load images #1649
Merged
Load images #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure Renovate
wind57
commented
Apr 30, 2024
| @@ -63,8 +63,8 @@ public void start() { | |||
| hostPodWatcher.start(); | |||
| scheduledExecutorService = Executors.newSingleThreadScheduledExecutor(); | |||
| scheduledExecutorService.scheduleAtFixedRate(leadershipController::update, | |||
| leaderProperties.getUpdatePeriod().toMillis(), | |||
There was a problem hiding this comment.
nothing changed here, just formatting
wind57
commented
Apr 30, 2024
| @@ -65,7 +65,9 @@ static void beforeAll() throws Exception { | |||
| Commons.validateImage(IMAGE_NAME, K3S); | |||
| Commons.loadSpringCloudKubernetesImage(IMAGE_NAME, K3S); | |||
|
|
|||
| Images.loadIstioctl(K3S); | |||
| Images.loadIstioCtl(K3S); | |||
wind57
commented
Apr 30, 2024
| @@ -54,7 +62,7 @@ public static String busyboxVersion() { | |||
| return imageVersion(BUSYBOX); | |||
| } | |||
|
|
|||
| public static String istioctlVersion() { | |||
| public static String istioVersion() { | |||
There was a problem hiding this comment.
renamed the method, since we want the same version for all 3 images
|
@ryanjbaxter saw your comment from yesterday, here is the fix. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.