Fabric8 it part 5 #1470
Merged
Fabric8 it part 5 #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fabric8-configmap-event-reload-patch-refactor-part-3
wind57
commented
Oct 7, 2023
| @@ -51,7 +51,6 @@ | |||
| <module>spring-cloud-kubernetes-fabric8-istio-it</module> | |||
| <module>spring-cloud-kubernetes-fabric8-client-discovery</module> | |||
| <module>spring-cloud-kubernetes-fabric8-client-loadbalancer</module> | |||
| <module>spring-cloud-kubernetes-fabric8-client-secrets-event-reload</module> | |||
There was a problem hiding this comment.
we already have an integration test that deals with reload in fabric8, but only for configmaps. This PR takes the secrets reload tests and moves them to the common place.
wind57
commented
Oct 7, 2023
| * - then we change data inside the secret, and we must see the updated value. | ||
| * </pre> | ||
| */ | ||
| static void testSecretReload(KubernetesClient client, K3sContainer container, String appLabelValue) { |
There was a problem hiding this comment.
this test was moved from the other module
|
@ryanjbaxter one more ready to look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.