fix(ocean/gcp): fixed min_size and max_size attributes to accept …

…0. (#601)
spotinst · Nov 26, 2024 · d13b34b · d13b34b
1 parent afe9ee6
commit d13b34b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## Unreleased
 
+## 1.199.2 (November, 26 2024)
+BUG FIXES:
+* resource/spotinst_ocean_gke_import: Fixed update of attribute `min_size` and `max_size`.
+
 ## 1.199.1 (November, 26 2024)
 BUG FIXES:
 * resource/spotinst_ocean_aws: Fixed `max_vcpu` and `max_memory_gib` fields to accept null.

diff --git a/spotinst/ocean_gke_import/fields_spotinst_ocean_gke_import.go b/spotinst/ocean_gke_import/fields_spotinst_ocean_gke_import.go
@@ -239,7 +239,6 @@ func Setup(fieldsMap map[commons.FieldName]*commons.GenericField) {
 		&schema.Schema{
 			Type:     schema.TypeInt,
 			Optional: true,
-			Computed: true,
 		},
 		func(resourceObject interface{}, resourceData *schema.ResourceData, meta interface{}) error {
 			clusterWrapper := resourceObject.(*commons.GKEImportClusterWrapper)
@@ -268,8 +267,8 @@ func Setup(fieldsMap map[commons.FieldName]*commons.GenericField) {
 		func(resourceObject interface{}, resourceData *schema.ResourceData, meta interface{}) error {
 			clusterWrapper := resourceObject.(*commons.GKEImportClusterWrapper)
 			cluster := clusterWrapper.GetCluster()
-			if v, ok := resourceData.GetOk(string(MaxSize)); ok {
-				cluster.Capacity.SetMaximum(spotinst.Int(v.(int)))
+			if v, ok := resourceData.Get(string(MaxSize)).(int); ok && v >= 0 {
+				cluster.Capacity.SetMaximum(spotinst.Int(v))
 			}
 			return nil
 		},
@@ -282,7 +281,6 @@ func Setup(fieldsMap map[commons.FieldName]*commons.GenericField) {
 		&schema.Schema{
 			Type:     schema.TypeInt,
 			Optional: true,
-			Computed: true,
 		},
 		func(resourceObject interface{}, resourceData *schema.ResourceData, meta interface{}) error {
 			clusterWrapper := resourceObject.(*commons.GKEImportClusterWrapper)
@@ -311,8 +309,8 @@ func Setup(fieldsMap map[commons.FieldName]*commons.GenericField) {
 		func(resourceObject interface{}, resourceData *schema.ResourceData, meta interface{}) error {
 			clusterWrapper := resourceObject.(*commons.GKEImportClusterWrapper)
 			cluster := clusterWrapper.GetCluster()
-			if v, ok := resourceData.GetOk(string(MinSize)); ok {
-				cluster.Capacity.SetMinimum(spotinst.Int(v.(int)))
+			if v, ok := resourceData.Get(string(MinSize)).(int); ok && v >= 0 {
+				cluster.Capacity.SetMinimum(spotinst.Int(v))
 			}
 			return nil
 		},
@@ -325,7 +323,6 @@ func Setup(fieldsMap map[commons.FieldName]*commons.GenericField) {
 		&schema.Schema{
 			Type:     schema.TypeInt,
 			Optional: true,
-			Computed: true,
 		},
 		func(resourceObject interface{}, resourceData *schema.ResourceData, meta interface{}) error {
 			clusterWrapper := resourceObject.(*commons.GKEImportClusterWrapper)