[cleanup] Remove deprecated 'spotbugsXmlOutput' as it is not used any…

…where
spotbugs · Dec 17, 2023 · 03351a5 · 03351a5
1 parent cd1e7e1
commit 03351a5
Show file tree

Hide file tree

Showing 40 changed files with 0 additions and 58 deletions.
diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml
@@ -62,7 +62,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/basic-1/pom.xml b/src/it/basic-1/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeTests>true</includeTests>
         </configuration>

diff --git a/src/it/change-xml-filename/pom.xml b/src/it/change-xml-filename/pom.xml
@@ -36,7 +36,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
           <spotbugsXmlOutputFilename>findbugsXml.xml</spotbugsXmlOutputFilename>

diff --git a/src/it/effort-default/pom.xml b/src/it/effort-default/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <effort>Default</effort>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/effort-max/pom.xml b/src/it/effort-max/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <effort>Max</effort>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/effort-min/pom.xml b/src/it/effort-min/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <effort>Min</effort>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/empty/pom.xml b/src/it/empty/pom.xml
@@ -56,7 +56,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/encoding-utf8/pom.xml b/src/it/encoding-utf8/pom.xml
@@ -44,7 +44,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/exclude-multi-list/pom.xml b/src/it/exclude-multi-list/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <excludeFilterFiles>
               <excludeFilterFile>whizbang/lib-filter.xml</excludeFilterFile>

diff --git a/src/it/exclude-multi/pom.xml b/src/it/exclude-multi/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <excludeFilterFile>whizbang/lib-filter.xml,filters/lib-filter2.xml</excludeFilterFile>
         </configuration>

diff --git a/src/it/exclude/pom.xml b/src/it/exclude/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <excludeFilterFile>filters/lib-filter2.xml</excludeFilterFile>
         </configuration>

diff --git a/src/it/experimental/pom.xml b/src/it/experimental/pom.xml
@@ -40,7 +40,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <threshold>Exp</threshold>
           <xmlOutput>true</xmlOutput>
         </configuration>

diff --git a/src/it/include-multi-list/pom.xml b/src/it/include-multi-list/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeFilterFiles>
               <includeFilterFile>whizbang/lib-filter.xml</includeFilterFile>

diff --git a/src/it/include-multi/pom.xml b/src/it/include-multi/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeFilterFile>whizbang/lib-filter.xml,filters/lib-filter2.xml</includeFilterFile>
         </configuration>

diff --git a/src/it/include/pom.xml b/src/it/include/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeFilterFile>whizbang/lib-filter.xml</includeFilterFile>
         </configuration>

diff --git a/src/it/multi-build/pom.xml b/src/it/multi-build/pom.xml
@@ -53,7 +53,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeFilterFile>whizbang/lib-filter.xml</includeFilterFile>
         </configuration>

diff --git a/src/it/multi/modules/pom.xml b/src/it/multi/modules/pom.xml
@@ -50,7 +50,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeFilterFile>whizbang/lib-filter.xml</includeFilterFile>
         </configuration>

diff --git a/src/it/nested/pom.xml b/src/it/nested/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <nested>true</nested>
         </configuration>

diff --git a/src/it/omitVisitors/pom.xml b/src/it/omitVisitors/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <omitVisitors>FindDeadLocalStores,UnreadFields</omitVisitors>
         </configuration>

diff --git a/src/it/onlyAnalyze/pom.xml b/src/it/onlyAnalyze/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <onlyAnalyze>BC_Unconfirmed_Cast</onlyAnalyze>
         </configuration>

diff --git a/src/it/onlyAnalyzeFileSource/pom.xml b/src/it/onlyAnalyzeFileSource/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <onlyAnalyze>file:only-analyze.txt</onlyAnalyze>
         </configuration>

diff --git a/src/it/pluginList-repo/pom.xml b/src/it/pluginList-repo/pom.xml
@@ -35,7 +35,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <plugins>
             <plugin>

diff --git a/src/it/pluginList/pom.xml b/src/it/pluginList/pom.xml
@@ -36,7 +36,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <pluginList>
             https://repo1.maven.org/maven2/com/mebigfatguy/sb-contrib/sb-contrib/@sb-contribVersion@/sb-contrib-@[email protected],

diff --git a/src/it/relaxed/pom.xml b/src/it/relaxed/pom.xml
@@ -35,7 +35,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/site-brazil/pom.xml b/src/it/site-brazil/pom.xml
@@ -49,7 +49,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/site-default/pom.xml b/src/it/site-default/pom.xml
@@ -47,7 +47,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/site-french/pom.xml b/src/it/site-french/pom.xml
@@ -47,7 +47,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/site-spanish/pom.xml b/src/it/site-spanish/pom.xml
@@ -47,7 +47,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/skip/pom.xml b/src/it/skip/pom.xml
@@ -42,7 +42,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <skip>true</skip>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <includeTests>true</includeTests>
         </configuration>

diff --git a/src/it/skipEmpty/pom.xml b/src/it/skipEmpty/pom.xml
@@ -62,7 +62,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <version>@pom.version@</version>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <skipEmptyReport>true</skipEmptyReport>
           <xmlOutput>true</xmlOutput>
         </configuration>

diff --git a/src/it/systemPropertyVariables/pom.xml b/src/it/systemPropertyVariables/pom.xml
@@ -38,7 +38,6 @@
           <systemPropertyVariables>
             <findsecbugs.taint.taintedsystemvariables>true</findsecbugs.taint.taintedsystemvariables>
           </systemPropertyVariables>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <plugins>
             <plugin>

diff --git a/src/it/threaded/pom.xml b/src/it/threaded/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
         </configuration>
       </plugin>

diff --git a/src/it/threshold-experimental/pom.xml b/src/it/threshold-experimental/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <threshold>Exp</threshold>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/threshold-high/pom.xml b/src/it/threshold-high/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <threshold>High</threshold>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/threshold-low/pom.xml b/src/it/threshold-low/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <threshold>Low</threshold>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <relaxed>true</relaxed>
         </configuration>

diff --git a/src/it/trace/pom.xml b/src/it/trace/pom.xml
@@ -41,7 +41,6 @@
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <trace>true</trace>
         </configuration>

diff --git a/src/it/userPrefs-override/pom.xml b/src/it/userPrefs-override/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <userPrefs>${project.basedir}/edu.umd.cs.findbugs.core.prefs</userPrefs>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
           <effort>Max</effort>
           <relaxed>true</relaxed>

diff --git a/src/it/userPrefs/pom.xml b/src/it/userPrefs/pom.xml
@@ -37,7 +37,6 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <userPrefs>${project.basedir}/edu.umd.cs.findbugs.core.prefs</userPrefs>
-          <spotbugsXmlOutput>true</spotbugsXmlOutput>
           <xmlOutput>true</xmlOutput>
 <!--
           <effort>Max</effort>

diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy
@@ -67,16 +67,6 @@ abstract class BaseViolationCheckMojo extends AbstractMojo {
     @Parameter(defaultValue = '${project.build.directory}', required = true)
     File xmlOutputDirectory
 
-    /**
-     * This has been deprecated and is on by default.
-     *
-     * @since 1.2.0
-     *
-     */
-    @Deprecated
-    @Parameter(defaultValue = "true")
-    boolean spotbugsXmlOutput
-
     /**
      * Specifies the directory where the Spotbugs native xml output will be generated.
      *

diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy
@@ -123,16 +123,6 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait {
     @Parameter(defaultValue = '${project.build.directory}', required = true)
     File xmlOutputDirectory
 
-    /**
-     * This has been deprecated and is on by default.
-     *
-     * @since 1.2.0
-     *
-     */
-    @Deprecated
-    @Parameter(defaultValue = "true")
-    boolean spotbugsXmlOutput
-
     /**
      * Specifies the directory where the Spotbugs native xml output will be generated.
      *