Skip to content

Commit

Permalink
Merge pull request #13 from splunk-soar-connectors/next
Browse files Browse the repository at this point in the history
Merging next to main for release 2.2.0
  • Loading branch information
ishans-crest authored Oct 4, 2022
2 parents 2cd8b6e + aa64df7 commit 8f79cfe
Show file tree
Hide file tree
Showing 29 changed files with 852 additions and 250 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Linting
on: [push, pull_request]
jobs:
lint:
lint:
# Run per push for internal contributers. This isn't possible for forked pull requests,
# so we'll need to run on PR events for external contributers.
# String comparison below is case insensitive.
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/review-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Review Release
concurrency:
group: app-release
cancel-in-progress: true
permissions:
contents: read
id-token: write
statuses: write
on:
workflow_dispatch:
inputs:
task_token:
description: 'StepFunction task token'
required: true

jobs:
review:
uses: 'phantomcyber/dev-cicd-tools/.github/workflows/review-release.yml@main'
with:
task_token: ${{ inputs.task_token }}
secrets:
resume_release_role_arn: ${{ secrets.RESUME_RELEASE_ROLE_ARN }}
6 changes: 3 additions & 3 deletions .github/workflows/semgrep.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Semgrep
on:
on:
pull_request_target:
branches:
- next
Expand All @@ -21,8 +21,8 @@ jobs:
echo "REPOSITORY=${{ github.event.pull_request.head.repo.full_name }}" >> $GITHUB_ENV
echo "REF=${{ github.event.pull_request.head.ref }}" >> $GITHUB_ENV
- uses: 'phantomcyber/dev-cicd-tools/github-actions/semgrep@main'
with:
with:
SEMGREP_DEPLOYMENT_ID: ${{ secrets.SEMGREP_DEPLOYMENT_ID }}
SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
REPOSITORY: ${{ github.repository }}
REPOSITORY: ${{ github.repository }}
REF: ${{ github.ref }}
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
repos:
- repo: https://github.com/phantomcyber/dev-cicd-tools
rev: v1.11
rev: v1.13
hooks:
- id: org-hook
- id: package-app-dependencies
- repo: https://github.com/Yelp/detect-secrets
rev: v1.2.0
rev: v1.3.0
hooks:
- id: detect-secrets
args: ['--no-verify', '--exclude-files', '^taniumrest.json$']
args: ['--no-verify', '--exclude-files', '^taniumrest.json$', '^README.md$']
2 changes: 1 addition & 1 deletion Phantom-All-Questions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@
</content_set_role_privilege>
</content_set_role_privileges>
</content_set_role>
</content>
</content>
2 changes: 1 addition & 1 deletion Phantom-Run-Actions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@
</content_set_role_privilege>
</content_set_role_privileges>
</content_set_role>
</content>
</content>
112 changes: 82 additions & 30 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion logo_taniumrest.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion logo_taniumrest_dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions readme.html
Original file line number Diff line number Diff line change
Expand Up @@ -139,26 +139,26 @@ <h2>Permissions for Interacting with Tanium REST API</h2>
Please ensure the account you used to configure the Tanium REST API app has access to any machines you run queries or actions on.</li>
</ul>
<br>
<li>Suggested Roles for Phantom Account in Tanium</li>
<li>Suggested Roles for SOAR Account in Tanium</li>
<ul>
<li>The following Tanium Roles shown below can be configured within Tanium and applied to the account used to connect to Phantom.
Note that these roles represent guidance by the Splunk Phantom team based on testing against Tanium 7.3.314.
<li>The following Tanium Roles shown below can be configured within Tanium and applied to the account used to connect to SOAR.
Note that these roles represent guidance by the Splunk SOAR team based on testing against Tanium 7.3.314.
<b>The permissions required in your environment may vary.</b></li>
<li>On Tanium 7.3.314, roles can be configured by selecting Permissions > Roles in the Tanium UI.
Roles can be applied to a user account by selecting Administration > Users > (View User) > Edit Roles in the Tanium UI.</li>
<li>Alternatively, you can <b>Import from XML</b> directly under Permissions > Roles in the Tanium UI. The XML files containing
the roles described below are attached to this app's folder.</li>
<br>
<code>
<b>Role #1 Name:</b> Phantom All Questions
<b>Role #1 Name:</b> SOAR All Questions
<ul>
<li><b>Permissions:</b> Can Ask Question and Saved Question. Needed for run query and list processes actions. </li>
<li><b>Ask Dynamic Question:</b> Yes</li>
<li><b>Show Interact:</b> Yes</li>
<li><b>Advanced Permissions:</b> Read Sensor, Read Saved Question</li>
</ul>
<br>
<b>Role #2 Name:</b> Phantom Actions
<b>Role #2 Name:</b> SOAR Actions
<ul>
<li><b>Permissions:</b> Can execute actions only. Needed for execute action and terminate process.</li>
<li><b>Show Interact:</b> Yes</li>
Expand Down
1 change: 1 addition & 0 deletions release_notes/2.2.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Fixed the custom view for 'get question results' action
Loading

0 comments on commit 8f79cfe

Please sign in to comment.