Bugfixes (mostly for ARM compatibility) and long read test data #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing default return value for IsGCRich function
k was not initialised to zero before being used
Specifying char as signed to ensure compatibility with ARM architecture
|
CC @mourisl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is mainly for stability and compatibility related changes. Additionally, some minimal long read test data was added to 'example'.
List of changes:
char noncanonStrandInfoinFindJunction.cppas signed, which fixed silent nonsense data fromjuncon AArch64 machinesAdditional details can be found in the commit comments and PRs in my fork!