Fix APPLICATION_ROOT example in docs #1270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the application is hosted on the path
/somestring
, static asset paths need to have prefix/somestring/static/
but settingAPPLICATION_ROOT
to "somestring" will result in a relative path which will give a 4XX. Using "/somestring" fixes this.e.g. static assets should look like this in source:
but without the leading slash they have
href="somestring/static/css/main.css"
which results in a network request for{DOMAIN}/somestring/{PROJECT_NAME}/somestring/static/css/main.css
The test suite includes the leading slash in
test_prefixed
:ihatemoney/ihatemoney/tests/main_test.py
Lines 76 to 77 in 76e8b3b
Also fix default value, which is "/" and not the empty string:
ihatemoney/ihatemoney/default_settings.py
Line 13 in 76e8b3b
ihatemoney/Dockerfile
Line 29 in 76e8b3b
ihatemoney/docker-compose.yml
Line 38 in 76e8b3b
ihatemoney/ihatemoney/conf-templates/ihatemoney.cfg.j2
Lines 50 to 51 in 76e8b3b
ihatemoney/ihatemoney/tests/main_test.py
Line 72 in 76e8b3b