Doc edits for Windows users and Light/Dark Mode toggle #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Commits on August 8th were already in master branch on my repo
I reduced the amount of commits by doing
git diff master..<feature-branches> | git apply -
and then applying the changes.Doc Changes
All the August 8th commits are edits to the
pb/README.md
doc and illustrate a Windows set up with Docker. I made some slight edits to uncapitalized letters, misspellings, and some extra clarifications..Overall, I used the
./README.md
file to illustrate a clear set up process in the following order: With Docker, With pocketbase binary, and with Go Tools installed.Frontend Changes
Removed the
--background-color-dark
SCSS variable from the mainapp.scss
file. This allowed for thewater.css
CDN to take more control.Added a
<ThemeToggle />
component as a button to toggle the light and dark theme of the site. Seeing how the website generally stems from a CDNwater.css
, I checked the website and the terse documentation and came up with a solution where the CDN renders a light and dark through interaction with this component.app.html
upon loading reads local storage and determines which CDN link to render. This way changes are dynamic and persistent.feather-icons
instead of just having the word "Toggle" written in the buttonConclusion
Light mode and dark mode is fully controlled by the CDN now and this paves the way to clean up a lot of the CSS. Now we can measure which elements to override on both modes