Display the number of unread mentions on the application tray icon #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armiol
requested changes
Dec 9, 2024
There was a problem hiding this comment.
@MykytaPimonovTD mostly LGTM. In addition to my comments, it would be nice to have an issue to address the icon-related issue you've described, once it's doable via the Compose API (and have the issue linked here).
In turn, in the issue, I would have a link to some piece of Compose docs (or their issue tracker) which deems impossible to do what we need it to do.
desktop/src/main/kotlin/io/spine/examples/pingh/desktop/Tray.kt
Outdated
Show resolved
Hide resolved
armiol
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds a badge to the application tray icon, displaying the number of unread mentions for a logged-in user.
The badge is displayed if the number of unread mentions exceeds 0.
A demonstration of this feature is available in the following video:
Screen.Recording.2024-12-09.at.16.26.21.mov
As noted in #71, the existing toolkit does not support both an adaptive application tray icon and a colored badge, which led to the theme-based color change being disabled. Now, the icon remains consistent:
Screen.Recording.2024-12-09.at.16.16.52.mov