Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kernel sends GARPs to avoid communication failures #4681

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

#4654

Signed-off-by: Cyclinder Kuo <[email protected]>
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.43%. Comparing base (1bbe20c) to head (99209ea).
Report is 1 commits behind head on release-v0.8.

Files with missing lines Patch % Lines
cmd/spiderpool/cmd/command_add.go 60.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.8    #4681      +/-   ##
================================================
- Coverage         76.48%   76.43%   -0.05%     
================================================
  Files                51       51              
  Lines              5907     5920      +13     
================================================
+ Hits               4518     4525       +7     
- Misses             1212     1216       +4     
- Partials            177      179       +2     
Flag Coverage Δ
unittests 76.43% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/spiderpool/cmd/command_add.go 71.66% <60.00%> (-1.39%) ⬇️

@cyclinder cyclinder merged commit 0d62811 into spidernet-io:release-v0.8 Feb 24, 2025
31 of 38 checks passed
cyclinder added a commit to cyclinder/spiderpool that referenced this pull request Feb 24, 2025
…io#4681)

* Ensure kernel sends GARPs to avoid communication failures (spidernet-io#4649)

Signed-off-by: Cyclinder Kuo <[email protected]>

* Bump github actions deps

Signed-off-by: Cyclinder Kuo <[email protected]>

---------

Signed-off-by: Cyclinder Kuo <[email protected]>
cyclinder added a commit to cyclinder/spiderpool that referenced this pull request Feb 24, 2025
…io#4681)

* Ensure kernel sends GARPs to avoid communication failures (spidernet-io#4649)

Signed-off-by: Cyclinder Kuo <[email protected]>

* Bump github actions deps

Signed-off-by: Cyclinder Kuo <[email protected]>

---------

Signed-off-by: Cyclinder Kuo <[email protected]>
cyclinder added a commit to cyclinder/spiderpool that referenced this pull request Feb 24, 2025
…io#4681)

* Ensure kernel sends GARPs to avoid communication failures (spidernet-io#4649)

Signed-off-by: Cyclinder Kuo <[email protected]>

* Bump github actions deps

Signed-off-by: Cyclinder Kuo <[email protected]>

---------

Signed-off-by: Cyclinder Kuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant