-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpiderMultusConfig: Add mtu size support for macvlan / ipvlan / sriov #4636
SpiderMultusConfig: Add mtu size support for macvlan / ipvlan / sriov #4636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4636 +/- ##
==========================================
- Coverage 75.68% 75.28% -0.40%
==========================================
Files 56 56
Lines 6765 6765
==========================================
- Hits 5120 5093 -27
- Misses 1431 1462 +31
+ Partials 214 210 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
be8393c
to
9b2d918
Compare
需要明确几点
|
|
|
这个 PR 只是在 spiderMultusConfig 中新增 mtu 字段,翻译到 Multus NAD, 具体是由 CNI(macvlan,ipvlan) 配置的
|
e3cd132
to
df578ed
Compare
Signed-off-by: Cyclinder Kuo <[email protected]>
df578ed
to
1d90f42
Compare
@@ -71,6 +71,7 @@ This is the SpiderReservedIP spec for users to configure. | |||
| master | the Interfaces on your master, you could specify a single one Interface<br/> or multiple Interfaces to generate one bond Interface | list of strings | required | | | |||
| vlanID | vlan ID | int | optional | [0,4094] | | |||
| bond | expected bond Interface configurations | [BondConfig](./crd-spidermultusconfig.md#bondconfig) | optional | | | |||
| mtu | mtu of the Interface | int | optional | the max mtu can't be over than the max mtu of the Interface | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可在 ai 部署文档中 的相关步骤中 提及,如何适配 mtu
否则 这个 等于没交付出去
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4646 中提及了
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #4422
Special notes for your reviewer:
SpiderMultusConfig: Add mtu size support for macvlan and ipvlan