Fixed some incorrect labels and added some e2e. #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
requested review from
weizhoublue,
bzsuni and
Icarus9913
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 49 49
Lines 5351 5351
=======================================
Hits 4337 4337
Misses 856 856
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/hold rebase #3088 |
ty-dc
force-pushed
the
e2e/new-7
branch
2 times, most recently
from
00ae022 to
fe60e82
Compare
Icarus9913
reviewed
Jan 15, 2024
.github/workflows/e2e-init.yaml
Outdated
| @@ -141,6 +141,7 @@ jobs: | |||
| echo "The current kubernetes version is ${{ inputs.k8s_version }} , ignore to install openvswitch due to Kind base image outdated" | |||
| INSTALL_OVS_VALUE=false; | |||
| fi | |||
| echo "INSTALL_OVS=${INSTALL_OVS_VALUE}" >> $GITHUB_ENV | |||
Icarus9913
reviewed
Jan 15, 2024
.github/workflows/e2e-init.yaml
Outdated
| @@ -165,6 +166,7 @@ jobs: | |||
| make ${{ matrix.e2e_test_mode }} -e E2E_CLUSTER_NAME=${{ env.E2E_CLUSTER_NAME }} \ | |||
| -e E2E_GINKGO_LABELS=${E2E_LABELS} \ | |||
| -e E2E_TIMEOUT=${{ env.E2E_TIME_OUT }} \ | |||
| -e INSTALL_OVS=${{ env.INSTALL_OVS }} \ | |||
There was a problem hiding this comment.
use the E2E codes to check whether we have ovs SMC or IPPool resource
There was a problem hiding this comment.
I don't need ovs, I just need to confirm that the node has an additional NIC for NIC abnormality testing, such as eth1.
But you're right, I shouldn't judge in CI, put it in It.
Signed-off-by: ty-dc <[email protected]>
weizhoublue
approved these changes
Jan 15, 2024
Icarus9913
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: