Add e2e for active-standby switching of spidercontroller #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
force-pushed
the
e2e/active—standby
branch
from
be0d108 to
8175097
Compare
ty-dc
changed the title
ty-dc
changed the title
ty-dc
force-pushed
the
e2e/active—standby
branch
2 times, most recently
from
170fd48 to
34a0f45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
- Coverage 81.15% 81.10% -0.06%
==========================================
Files 49 49
Lines 5334 5334
==========================================
- Hits 4329 4326 -3
- Misses 850 852 +2
- Partials 155 156 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
force-pushed
the
e2e/active—standby
branch
from
34a0f45 to
a54ab2e
Compare
Icarus9913
reviewed
Jan 10, 2024
Comment on lines
+253
to
+254
| if *spiderControllerLeases.Spec.HolderIdentity == v.Name { | ||
| GinkgoWriter.Printf("the spiderpool-controller current master is: %v \n", *spiderControllerLeases.Spec.HolderIdentity) |
There was a problem hiding this comment.
要对spiderControllerLeases.Spec.HolderIdentity这个做判断是否为空指针
Icarus9913
reviewed
Jan 10, 2024
| out, err := frame.DockerExecCommand(ctx, nodeList.Items[0].Name, metricsHealthyCheck) | ||
| if err != nil { | ||
| time.Sleep(common.ForcedWaitingTime) | ||
| frame.Log("failed to check metrics healthy, error: %v, output log is: %v ", err, string(out)) |
There was a problem hiding this comment.
这个函数的 err 只是记录了 exit 1 、exit status 7 等，并没有对应的错误信息
此处的 out 会有类似
output log is:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (7) Failed to connect to 172.18.0.3 port 571: Connection refused
a54ab2e to
100304d
Compare
Signed-off-by: ty-dc <[email protected]>
ty-dc
force-pushed
the
e2e/active—standby
branch
from
100304d to
58386b3
Compare
weizhoublue
approved these changes
Jan 11, 2024
Icarus9913
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: