Spidercoordinator: It able to get CIDR from kubeadm-config

[cyclinder]

If the kube-controller-manager Pod is running as systemd process rather than Pod, In this case, We can't get the CIDR from the KCM Pod. We can get the CIDR from the kubeadm-config configMap.

Thanks for contributing!

What type of PR is this?

• release/bug

What this PR does / why we need it:

Kube-controller-pod is running as systemd process rather than a pod, We can't get the cluster CIDR in this case.

1. We get the clusterCIDR from kubeadm-config ConfigMap first.
2. If kubeadm-config ConfigMap does exist in cluster, we can get it from kube-controller-manager.

Which issue(s) this PR fixes:

Fixes #3054

Special notes for your reviewer:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e247e6d) 81.05% compared to head (712f10c) 81.10%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3062      +/-   ##
==========================================
+ Coverage   81.05%   81.10%   +0.05%     
==========================================
  Files          49       49              
  Lines        5351     5351              
==========================================
+ Hits         4337     4340       +3     
+ Misses        856      854       -2     
+ Partials      158      157       -1     

Flag	Coverage Δ
unittests	81.10% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[weizhoublue]

there are so many cases already and it is import . Is it possible to design relevant E2E cases to long term test ?

and it could finish #2905 as well recently in another PR

[cyclinder]

#2927 is some E2E cases for spidercoordiantor, we can also add a case for these changes: delete the kubeadm-config configMap and see if works, but we can't delete kube-controller-manager pod, it's so dangerous. It can be finished in #2905.

[weizhoublue]

#2927 is some E2E cases for spidercoordiantor, we can also add a case for these changes: delete the kubeadm-config configMap and see if works, but we can't delete kube-controller-manager pod, it's so dangerous. It can be finished in #2905.

do you already have two cases to get CIDR from configmap and pod yaml separately ?

[cyclinder]

we can also add a case for these changes: delete the kubeadm-config configMap and see if works, but we can't delete kube-controller-manager pod, it's so dangerous. It can be finished in #2905.

Not yet. It can be finished in this PR Or #2905

[weizhoublue]

I suggest to finish the E2E together for verification

[weizhoublue]

I suggest to finish the E2E together for verification

is there any update

[cyclinder]

is there any update

Still working on this

[cyclinder]

/cc @weizhoublue