Add clean egress #1178
Merged
Add clean egress #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 19 19
Lines 3170 3170
=======================================
Hits 2668 2668
Misses 390 390
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. |
bzsuni
force-pushed
the
bz/e2e/clean-egress
branch
from
d045808 to
d065b08
Compare
lou-lan
reviewed
Jan 30, 2024
bzsuni
force-pushed
the
bz/e2e/clean-egress
branch
2 times, most recently
from
483984e to
49cc9ce
Compare
lou-lan
previously approved these changes
Jan 30, 2024
weizhoublue
reviewed
Jan 30, 2024
tools/scripts/cleanCRD.sh
Outdated
| # kubectl patch crd egresstunnels.egressgateway.spidernet.io -p '{"metadata":{"finalizers": []}}' --type=merge | ||
| # kubectl patch crd egressgateways.egressgateway.spidernet.io -p '{"metadata":{"finalizers": []}}' --type=merge | ||
|
|
||
| kubectl get crd | grep egressgateway.spidernet.io | awk '{print $1}' | xargs kubectl delete crd |
There was a problem hiding this comment.
如果这不是我们 文档中的 卸载的标准流程，不应该有这个脚本
bzsuni
force-pushed
the
bz/e2e/clean-egress
branch
from
49cc9ce to
eb9195c
Compare
weizhoublue
reviewed
Jan 31, 2024
| @@ -174,9 +174,20 @@ jobs: | |||
| path: ${{ env.E2E_GINKGO_REPORT_PATH }} | |||
| retention-days: 30 | |||
|
|
|||
| - name: helm uninstalls egress | |||
There was a problem hiding this comment.
这个CI 目的不是简单为了卸载，而是 在按照标准卸载流程后，确认是否还有残余垃圾。因此，是否有该 确认 代码 ？
|
any update ? |
do it tody |
Signed-off-by: bzsuni <[email protected]>
bzsuni
force-pushed
the
bz/e2e/clean-egress
branch
from
eb9195c to
0452110
Compare
lou-lan
approved these changes
Feb 29, 2024
weizhoublue
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #670