Add own modified version of Datafusion optimize_projections rule
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
changed the title
optimize_projections ruleoptimize_projections optimizer rule
sgrebnov
force-pushed
the
sgrebnov/custom-optimize-projections-rule
branch
from
7243970 to
df63d48
Compare
sgrebnov
changed the title
optimize_projections optimizer ruleoptimize_projections rule
sgrebnov
commented
Nov 29, 2024
datafusion-federation/src/optimize/optimize_projections/required_indices.rs
Show resolved
Hide resolved
sgrebnov
commented
Nov 29, 2024
sgrebnov
commented
Nov 29, 2024
phillipleblanc
previously approved these changes
Nov 29, 2024
Co-authored-by: Phillip LeBlanc <[email protected]>
phillipleblanc
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
PR introduces a modified version of DataFusion's
OptimizeProjectionsrule, updated to allow the DataFusion unparser to correctly convert the optimized plan to SQL. It also maintains a simple and readable query layout.See DataFusion discussion for more details on motivation to create own modified version of the rule instead of modifying the original one (DF).